Skip to content

ci: removed multiple unused CI scripts - #7641

Merged
PastaPastaPasta merged 2 commits into
dashpay:developfrom
knst:cleanup-ci-unused
Aug 28, 2026
Merged

ci: removed multiple unused CI scripts#7641
PastaPastaPasta merged 2 commits into
dashpay:developfrom
knst:cleanup-ci-unused

Conversation

@knst

@knst knst commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Some scripts for "CI" exists as they have been backported from Bitcoin Core but they are completely irrelevant, in non-working condition.
Beside extra conflicts to resolve for Dash Core when backporting changes from Bitcoin Core, they also masks real changes that should be done during backports but in other files, such as ci/dash/build_src.sh or ci/dash/lint-tidy.sh.

What was done?

Removed:

  • ci/test/04_install.sh
  • ci/test/05_before_script.sh
  • ci/test/wrap-wine.sh
  • ci/test_run_all.sh
  • ci/dash/build_depends.sh

Updated ci/README.md accordingly current status.

How Has This Been Tested?

N/A

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

knst added 2 commits August 27, 2026 23:57
Nothing references ci/dash/build_depends.sh: the depends build moved
into .github/workflows/build-depends.yml, which runs `make -C depends`
inline.
Dash CI runs on GitHub Actions via ci/dash/*.sh, which selects a ci/test/00_setup_env*.sh configuration through ci/dash/matrix.sh.
The staged Bitcoin Core pipeline was never wired into it: ci/test_run_all.sh sources 04_install.sh and 05_before_script.sh and then stops, because the 06_script_*.sh stages were never adopted, so it sets up an environment without running a single test.
Nothing references these files except ci/README.md, yet they keep absorbing backport conflicts and maintenance that has no effect on CI.

Same reasoning as the earlier .cirrus.yml (dashpay#6704) removal

Also removed as fully unreferenced: ci/test/wrap-wine.sh

ci/README.md is trimmed accordingly; its removed examples also cited
ci/test/00_setup_env_arm.sh, a file that does not exist.
@knst knst added this to the 24 milestone Aug 27, 2026
@thepastaclaw

thepastaclaw commented Aug 27, 2026

Copy link
Copy Markdown

✅ Final review complete — no blockers (commit e9b40c4)

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 286a83e3-750f-4236-860e-f1388a4c04e9

📥 Commits

Reviewing files that changed from the base of the PR and between d1f7ff5 and e9b40c4.

📒 Files selected for processing (6)
  • ci/README.md
  • ci/dash/build_depends.sh
  • ci/test/04_install.sh
  • ci/test/05_before_script.sh
  • ci/test/wrap-wine.sh
  • ci/test_run_all.sh
💤 Files with no reviewable changes (5)
  • ci/test/wrap-wine.sh
  • ci/test/05_before_script.sh
  • ci/test_run_all.sh
  • ci/dash/build_depends.sh
  • ci/test/04_install.sh

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The CI README now documents configuration files selected by BUILD_TARGET and driven by GitHub Actions workflows. It identifies 00_setup_env.sh as the default configuration with fallback values. The change also removes legacy dependency, installation, pre-script, Wine wrapper, and test orchestration scripts.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e9b40

This change removes unused CI scripts and updates the CI documentation without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removal of multiple unused CI scripts.
Description check ✅ Passed The description directly explains why the unused CI scripts were removed, lists the affected files, and notes the documentation update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Codex/Sol only (Phase 2 disabled)

At exact head e9b40c4, the PR cleanly removes the obsolete staged CI pipeline and superseded depends helper while updating ci/README.md to describe the active GitHub Actions setup. The active workflows source ci/dash/matrix.sh, build depends directly, and retain no references to the deleted entry points, so no in-scope defect was found.
Source: codex-general, codex-dash-core-commit-history, and codex-backport-reviewer (their exact backend model IDs are not exposed in the supplied evidence); final verifier backend model grok-4.5. Orchestration-only: openclaw-agent/cliproxy/gpt-5.6-sol (not reviewer evidence).

Validated zero-blocker Codex/Sol precheck evidence was promoted to final because Phase 2 (Sonnet/Opus) is temporarily disabled. This is Codex/Sol-only final validation, not Codex + Sonnet/Opus coverage.

Review provenance

  • Codex reviewers: gpt-5.6-sol — general (completed), gpt-5.6-sol — dash-core-commit-history (completed), gpt-5.6-sol — backport-reviewer (completed)
  • Verifier: gpt-5.6-sol — verifier
  • Sonnet/Opus: not run (Phase 2 disabled — temporary Codex/Sol-only final)
  • Secondary pass: disabled (temporary_phase2_sonnet_disable)

@PastaPastaPasta
PastaPastaPasta merged commit e2a96da into dashpay:develop Aug 28, 2026
42 of 43 checks passed
PastaPastaPasta added a commit that referenced this pull request Sep 8, 2026
…itcoin#21865, bitcoin#23008, bitcoin#23619, bitcoin#24384, bitcoin#24522, bitcoin#24705, bitcoin#26683, bitcoin#26843, bitcoin#27436, bitcoin#27495, bitcoin#27699, bitcoin#27737, bitcoin#28185, bitcoin#29676, bitcoin#29742, bitcoin#29800, bitcoin#29837, bitcoin#31592 [msan preparation]

db463c4 ci: build an MSan-instrumented libc++ into a dedicated CI image (Konstantin Akimov)
c4cecb6 ci: dashify the msan job configuration (Konstantin Akimov)
cf5cee3 Merge bitcoin#27699: random: drop syscall wrapper usage for getrandom() (Konstantin Akimov)
2f59ed8 Merge bitcoin#31592: ci: Run functional tests in msan task (Konstantin Akimov)
faa52f0 Merge bitcoin#29837: ci: disable `_FORTIFY_SOURCE` with MSAN (Konstantin Akimov)
b0e98fc Merge bitcoin#29742: ci: remove --with-asm=no (secp256k1) from MSAN jobs (Konstantin Akimov)
85fd51b Merge bitcoin#29800: ci: Drop duplicated compiler flags (Konstantin Akimov)
9e0c60c Merge bitcoin#29676: ci: Bump msan to llvm-18 (Konstantin Akimov)
0329549 partial Merge bitcoin#28185: ci: Use hard-coded root path for CI containers (bugfix) (Konstantin Akimov)
b5c04b8 Merge bitcoin#27495: ci: Use LLVM 17.0.6 & DEBUG=1 in depends for MSAN jobs (Konstantin Akimov)
e0d263c Merge bitcoin#27737: ci: compile Clang and compiler-rt in msan jobs (Konstantin Akimov)
b5d3242 Merge bitcoin#27436: test: LLVM/Clang 16 for MSAN jobs (Konstantin Akimov)
2008a8e Merge bitcoin#23619: build: Propagate user-defined flags to host packages (Konstantin Akimov)
2079fb6 Merge bitcoin#26843: ci: Fix ci_native_fuzz_msan CONTAINER_NAME (Konstantin Akimov)
d06f428 partial Merge bitcoin#26683: ci: Use `CONFIG_SITE` variable and `--prefix` option properly (Konstantin Akimov)
243c15a Merge bitcoin#23008: ci: Use clang-12 and libcxx-12 for msan (Konstantin Akimov)
3aa2a09 Merge bitcoin#24705: ci: note why bdb is disabled in msan jobs (Konstantin Akimov)
dad387f Merge bitcoin#24522: ci: remove compiled-but-unused BDB from MSAN job (Konstantin Akimov)
6a58865 Merge bitcoin#24384: ci: remove `boost_cxxflags` from MSAN CIs (Konstantin Akimov)
7d42ae4 Merge bitcoin#21865: ci: Properly pass msan cflags (Konstantin Akimov)
70256f7 Merge bitcoin#21864: fix permissions on 00_setup_env_native_fuzz_with_msan.sh (Konstantin Akimov)
3bf7863 Merge bitcoin#21852: ci: Add msan fuzz config (Konstantin Akimov)
14c365a Merge bitcoin#18288: build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  Bitcoin Core has msan [memory sanitizer] on CI.

  This PR meant to bring msan to Dash Core. Though, due to low performance of asan [address sanitizer] and extra load for our CI queue, enabling of msan is postponed until we will have bigger resources / faster CI or msan's jobs suddenly will become much faster].

  ## What was done?
  There's msan related backports up to the moment when CI with msan is fully functioning and working.

  This PR DOES NOT activate msan and DOES NOT create any extra jobs.

  Most of the changes in these backports are inside  `ci/test/00_setup_env_native_msan.sh` and `ci/test/00_setup_env_native_fuzz_with_msan.sh`.

  Some changes in backports are marked as "done" but in fact they are skipped due to non-existing files, see  #7641. The real changes are in the new file `contrib/containers/ci/ci-msan.Dockerfile`

  ## How Has This Been Tested?
  It has been tested on CI with fork of repo https://github.com/knst/dash/actions/runs/33092725515/job/98611087267 as correctly working but it is time / resources consuming, so, not enabled.
  Extra commits are extracted to new PR that doesn't meant to be merged at the moment, see #7643

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

Top commit has no ACKs.

Tree-SHA512: c99a8a5a68995cd59f8149c03af452f9ff09448cfb9255314b6ef797e7aad01b31c2b97a8fc611ae70ea4dfb71e58ff82308cbbb55985b6abaf810bc106877b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants