Skip to content

build!: use published bincode 2.1.0 for Git consumers - #948

Merged
QuantumExplorer merged 1 commit into
developfrom
codex/published-bincode-2-1
Sep 8, 2026
Merged

build!: use published bincode 2.1.0 for Git consumers#948
QuantumExplorer merged 1 commit into
developfrom
codex/published-bincode-2-1

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Platform and rust-dashcore are adopting the published grovedb-bincode and grovedb-bincode-derive 2.1.0 crates. GroveDB's workspace path dependencies still select repository-local copies for Git consumers, giving their types different bincode trait identities even at the same version.

Companion to Platform #4625 and rust-dashcore #1005.

What was done?

Remove the two workspace dependency path entries while retaining exact =2.1.0 version requirements. Git consumers now resolve the registry codec shared with the SDKs, without requiring a downstream Cargo override. The local fork packages remain workspace members for their own development and testing.

How Has This Been Tested?

  • cargo check --workspace --all-targets --all-features
  • cargo test -p grovedb-element -p grovedb-query --lib --all-features: 489 passed, one ignored.
  • Confirmed the published codec's Rust source matches the previously used fork implementation. No codec or proof implementation changes.

Breaking Changes

Git consumers must use the registry grovedb-bincode 2.1.0 crate to share Encode/Decode traits with GroveDB types. Existing serialized bytes and ordinary decoding behavior are unchanged. Published GroveDB packages already resolve registry dependencies.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 266931a5-b9ef-4afb-bac8-c60bfdf2c1a8

📥 Commits

Reviewing files that changed from the base of the PR and between 52ae761 and 0bb83cc.

📒 Files selected for processing (1)
  • Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@QuantumExplorer
QuantumExplorer merged commit 985ece6 into develop Sep 8, 2026
9 checks passed
@QuantumExplorer
QuantumExplorer deleted the codex/published-bincode-2-1 branch September 8, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant