Skip to content

feat(sdk)!: add scoped authentication key SDK support - #4655

Open
PastaPastaPasta wants to merge 1 commit into
feat/scoped-contract-auth-keysfrom
feat/scoped-contract-auth-sdk
Open

feat(sdk)!: add scoped authentication key SDK support#4655
PastaPastaPasta wants to merge 1 commit into
feat/scoped-contract-auth-keysfrom
feat/scoped-contract-auth-sdk

Conversation

@PastaPastaPasta

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Applications and wallets must preserve the scoped key permissions enforced by #4613. This PR is stacked on feat/scoped-contract-auth-keys (#4613) and contains the SDK changes only.

What was done?

  • Add native scope ABI fields, marshalling, cleanup, restore, and JNI transport; replace the foundation PR’s unsupported-scope guard with complete scope support.
  • Preserve scopes in Kotlin persistence (Room 11→12), Swift wrappers/key refresh, and WASM construction and serialization APIs.
  • Freeze the V4 SwiftData relationship component and migrate V4→V5 instead of changing V4’s checksum. Existing wallet/key relationships and Keychain references survive, and scope bytes persist across reopening.
  • Add the application integration guide and SDK regression/smoke coverage.

How Has This Been Tested?

Breaking Changes

Native libraries, generated headers, and Swift/Kotlin consumers must update together because public-key FFI layouts gain scope fields. Existing stores migrate with Room 11→12 and SwiftData V4→V5. Merge #4613 first; protocol-14 activation is required to register/use scoped keys.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0eb6619e-26a6-4a23-ba4e-228f1acfcc5a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit c519d1b) · triage: critical · Phase 2 only (queue backlog)

@PastaPastaPasta
PastaPastaPasta force-pushed the feat/scoped-contract-auth-sdk branch from 6b0244c to c519d1b Compare September 10, 2026 20:51

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 2 only (queue backlog)

The scoped authentication-key SDK support is propagated consistently across the native FFI, JNI/Kotlin transport and persistence, Swift wrappers and SwiftData migration, and WASM APIs. The reviewed changes preserve scoped permissions, validate and bound persisted scope data, maintain ownership and cleanup across FFI boundaries, and retain legacy contract-bound behavior; no actionable in-scope defects were identified.

Review provenance

Source: reviewer 1: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 2: gpt-6-astra (agent: phase2-reviewer, role: ffi-engineer); reviewer 3: gpt-6-astra (agent: phase2-reviewer, role: rust-quality); reviewer 4: gpt-6-astra (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6-astra (agent: astra-verifier, role: final-verifier)

  • Triage: critical by gpt-6-astra (effort low) — This is a large, cross-language change that modifies authentication key handling, FFI/JNI/WASM serialization, and durable Kotlin/Swift storage migrations, directly affecting cryptographic key permissions and persistence in files such as packages/rs-platform-wallet-ffi/src/identity_persistence.rs and DashModelContainer.swift.
  • Phase 1 reviewers: not run (skipped for throughput: 14 PRs queued, above the 10 limit)
  • Fresh verifier: gpt-6-astra — final-verifier; agent astra-verifier
  • Phase 2 reviewers: gpt-6-astra — general (completed, effort xhigh); agent phase2-reviewer, gpt-6-astra — ffi-engineer (completed, effort xhigh); agent phase2-reviewer, gpt-6-astra — rust-quality (completed, effort xhigh); agent phase2-reviewer, gpt-6-astra — security-auditor (completed, effort xhigh); agent phase2-reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants