feat(sdk)!: add scoped authentication key SDK support - #4655
feat(sdk)!: add scoped authentication key SDK support#4655PastaPastaPasta wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Final review complete — no blockers (commit c519d1b) · triage: critical · Phase 2 only (queue backlog) |
4345770 to
7ebb26e
Compare
7ebb26e to
6b0244c
Compare
6b0244c to
c519d1b
Compare
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 2 only (queue backlog)
The scoped authentication-key SDK support is propagated consistently across the native FFI, JNI/Kotlin transport and persistence, Swift wrappers and SwiftData migration, and WASM APIs. The reviewed changes preserve scoped permissions, validate and bound persisted scope data, maintain ownership and cleanup across FFI boundaries, and retain legacy contract-bound behavior; no actionable in-scope defects were identified.
Review provenance
Source: reviewer 1: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 2: gpt-6-astra (agent: phase2-reviewer, role: ffi-engineer); reviewer 3: gpt-6-astra (agent: phase2-reviewer, role: rust-quality); reviewer 4: gpt-6-astra (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6-astra (agent: astra-verifier, role: final-verifier)
- Triage:
criticalbygpt-6-astra(effort low) — This is a large, cross-language change that modifies authentication key handling, FFI/JNI/WASM serialization, and durable Kotlin/Swift storage migrations, directly affecting cryptographic key permissions and persistence in files such as packages/rs-platform-wallet-ffi/src/identity_persistence.rs and DashModelContainer.swift. - Phase 1 reviewers: not run (skipped for throughput: 14 PRs queued, above the 10 limit)
- Fresh verifier:
gpt-6-astra— final-verifier; agentastra-verifier - Phase 2 reviewers:
gpt-6-astra— general (completed, effort xhigh); agentphase2-reviewer,gpt-6-astra— ffi-engineer (completed, effort xhigh); agentphase2-reviewer,gpt-6-astra— rust-quality (completed, effort xhigh); agentphase2-reviewer,gpt-6-astra— security-auditor (completed, effort xhigh); agentphase2-reviewer
Issue being fixed or feature implemented
Applications and wallets must preserve the scoped key permissions enforced by #4613. This PR is stacked on
feat/scoped-contract-auth-keys(#4613) and contains the SDK changes only.What was done?
How Has This Been Tested?
Breaking Changes
Native libraries, generated headers, and Swift/Kotlin consumers must update together because public-key FFI layouts gain scope fields. Existing stores migrate with Room 11→12 and SwiftData V4→V5. Merge #4613 first; protocol-14 activation is required to register/use scoped keys.
Checklist: