test(drive): track latest protocol version in grovedb structure snapshot - #5154
PastaPastaPasta wants to merge 1 commit into
Conversation
#5043 introduced PLATFORM_V15 and made it latest, but the committed grovedb-structure.json and one structure test still expected protocol 14, so `structure::tests` has failed on v4.3-dev since it merged: - should_match_committed_grovedb_structure_json: regenerate the snapshot. Only the origin labels and latest_protocol_version change (14 -> 15); v15 has the same state structure as v14. - should_record_a_contract_layer_with_its_documents_on_top: read the expected origin from PlatformVersion::latest() instead of a hard-coded 14, so the next protocol bump does not break it again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: dashpay/platform/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🌳 GroveDB structure This pull request changes the described GroveDB structure. Open it in the structure viewer: new nodes glow, removed ones stay as ghosts, and the tour walks through each change. Changed (28 nodes)
Compared |
|
✅ Final review complete — no blockers (commit 85deb41) · triage: low |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
Verified the complete diff at head 85deb41: the assertion now follows the latest protocol version used by the generator and fixtures, and all 35 snapshot changes affect only version metadata, not tree structure. No in-scope defects were found; the edited file passes rustfmt and the diff passes whitespace checks, but Rust tests were not independently rerun during this verification.
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: architecture-layering); reviewer 3: glm-5.3-flash (agent: phase1-reviewer, role: platform-versioning); reviewer 4: glm-5.3-flash (agent: phase1-reviewer, role: rust-quality); reviewer 5: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 6: gpt-6-astra (agent: phase2-reviewer, role: architecture-layering); reviewer 7: gpt-6-astra (agent: phase2-reviewer, role: platform-versioning); reviewer 8: gpt-6-astra (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6-astra (agent: astra-verifier, role: final-verifier)
- Triage:
lowbygpt-6-astra(effort low) — The diff is a small, contained test maintenance change that updates snapshot protocol-version labels and replaces a hard-coded expected version with PlatformVersion::latest(), without changing production logic or storage structure. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer,glm-5.3-flash— architecture-layering (completed, effort high); agentphase1-reviewer,glm-5.3-flash— platform-versioning (completed, effort high); agentphase1-reviewer,glm-5.3-flash— rust-quality (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 97% left, weekly 97% left; passed overgemini-3.8-flash-high(antigravity below 15% reserve: weekly 13% left, 5h 100% left) - Fresh verifier:
gpt-6-astra— final-verifier; agentastra-verifier - Phase 2 reviewers:
gpt-6-astra— general (completed, effort medium); agentphase2-reviewer,gpt-6-astra— architecture-layering (completed, effort medium); agentphase2-reviewer,gpt-6-astra— platform-versioning (completed, effort medium); agentphase2-reviewer,gpt-6-astra— rust-quality (completed, effort medium); agentphase2-reviewer
|
@coderabbitai review No review for |
Issue being fixed or feature implemented
v4.3-devhas failed Rust workspace tests since #5043 (introduce protocol version 15) merged. Examples: run one38241d52, and the same two failures on #5151.The structure snapshot is generated at
PlatformVersion::latest(), which is now 15. The committed JSON and one assertion still said 14.What was done?
packages/rs-drive/grovedb-structure.jsonwithUPDATE_GROVEDB_STRUCTURE=1 cargo test -p drive --lib structure::tests. Only theoriginlabels (…@14→…@15) andlatest_protocol_version(14 → 15) change. PV15 lays out the same state as PV14, so there is no structural change.should_record_a_contract_layer_with_its_documents_on_topnow builds its expected origin fromPlatformVersion::latest()instead of a hard-coded14. That way the next protocol bump only needs the snapshot regenerated.How Has This Been Tested?
cargo test -p drive --lib structure::tests: 11 passed. Both tests failed before the change.rustfmt --checkon the edited test file.Breaking Changes
None. This changes only a test and its snapshot.
Checklist:
structure.rs, regeneratedgrovedb-structure.json, and checked the structure viewer link posted on this pull requestFor repository code-owners and collaborators only
🤖 Generated with Claude Code