Skip to content

ci: pin integrated runner controller revision - #5157

Merged
ktechmidas merged 1 commit into
dashpay:v4.2-devfrom
infraclaw-dash:ci/integrated-runner-controller-20260928
Sep 28, 2026
Merged

ktechmidas merged 1 commit into
dashpay:v4.2-devfrom
infraclaw-dash:ci/integrated-runner-controller-20260928

Conversation

@infraclaw-dash

@infraclaw-dash infraclaw-dash commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Adopt the integrated trusted controller revision after the legacy-template compatibility and candidate-status provenance fixes landed. The existing aaea7df12716c386db223ea67a853b6b0efbd45a pin includes the legacy fix but predates the corrected promotion status lookup.

7d901150bd3d0789d50c46f365b058f2f5f1f52d is the merged dashpay/dash-selfhosted-image main revision containing both dashpay/dash-selfhosted-image#7 and dashpay/dash-selfhosted-image#8. It retains the validated full/AMD64 NDK_VERSION / CMDLINE_VERSION aliases while using paginated full commit statuses in candidate_digest, selecting the newest logical context before checking creator, publisher workflow and immutable digest provenance.

Related Platform changes: #5155 (previous compatibility pin) and #5156 (merged full-status runner selector).

What was done?

Updated only the two trusted controller references in .github/workflows/runner-image-candidate.yml to the same exact integrated SHA:

  • Reusable workflow jobs.image.uses.
  • jobs.image.with.control_revision.

All other file bytes are unchanged, including permissions, secret names, concurrency and event gates. No manifest, recipe, image, application/runtime, runner-service, configuration or credential changes. No manual workflow dispatch, PR merge, or changes to PR #5151.

Host deployment is handled separately by the parent/host owner using the same integrated SHA. This PR does not deploy or claim activation of the host controller.

Requested reviewer: ktechmidas (review request, not assignment; API result will be reported separately).

How Has This Been Tested?

On Linux, from a fresh worktree based on upstream v4.2-dev at b81ed541ac518945c602618366d1e67f143a25f6:

  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/scripts/tests -v — 33 tests passed.
  • Parsed the workflow with PyYAML and asserted both references equal the exact integrated SHA.
  • Byte-for-byte assertion against the base file proves the only changes are the two old-to-new SHA replacements; exactly one file changed.
  • actionlint 1.7.12 on .github/workflows/runner-image-candidate.yml — passed.
  • git diff --check — passed; self-reviewed the complete two-line diff.
  • Inspected exact controller source at 7d901150bd3d0789d50c46f365b058f2f5f1f52d; verified merged legacy PR feat(wallet-lib): do not sync transactions if mnemonic is absent #7 (27c1666), CPU PR docs(sdk): provide getTransactionHistory #5 (92fcca1) and documentation PR build(sdk): upgrade to webpack 5 #6 (6eee512) are ancestors.
  • Ran that exact integrated controller revision's test_legacy_template_compat.py — 6 tests passed, including pinned legacy materialization with the known-good rendered hash and fail-closed unsupported/unknown placeholders.
  • Ran that exact integrated controller revision's test_candidate_status.py — 13 tests passed, covering captured API provenance, pagination, newest-status shadowing, malformed creators, and publisher/digest gates.

These are focused local checks, not claims of full image builds, application tests or host activation.

Breaking Changes

None. Only the paired trusted controller revision pins change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed
  • If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request

Existing tests were rerun; this pin-only change requires no new code comments, tests, documentation or GroveDB changes.

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

PR Hygiene · c4493d5

  • Bots — coderabbitai not yet · thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — not asked of a bot author
  • Within your 5 open PRs
  • Build running
  • Approvals
    • files with no dedicated owner (.github/workflows/runner-image-candidate.yml) — QuantumExplorer or shumkov

When every box is checked the PR Hygiene check passes and this can merge.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: df01e0c5-4a4c-4126-b99b-4b3daba0f9d8

📥 Commits

Reviewing files that changed from the base of the PR and between b81ed54 and c4493d5.

📒 Files selected for processing (1)
  • .github/workflows/runner-image-candidate.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v4.2.0 milestone Sep 28, 2026
@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Sep 28, 2026
@thepastaclaw

thepastaclaw commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 6th in line, estimated start in ~25 min (commit c4493d5)
Estimated review time once started: ~55 min (two-phase automated review; median of recent runs).

  • Request priority review — click to move this review to the front of the queue.

@ktechmidas
ktechmidas merged commit 99bc968 into dashpay:v4.2-dev Sep 28, 2026
19 of 20 checks passed
PastaPastaPasta added a commit that referenced this pull request Sep 28, 2026
Pick up #5157 (pin integrated runner controller revision).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@PastaPastaPasta PastaPastaPasta mentioned this pull request Sep 28, 2026
2 of 24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants