ci: pin integrated runner controller revision - #5157
ktechmidas merged 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: dashpay/platform/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Queued for automated review — 6th in line, estimated start in ~25 min (commit c4493d5)
|
Pick up #5157 (pin integrated runner controller revision). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Issue being fixed or feature implemented
Adopt the integrated trusted controller revision after the legacy-template compatibility and candidate-status provenance fixes landed. The existing
aaea7df12716c386db223ea67a853b6b0efbd45apin includes the legacy fix but predates the corrected promotion status lookup.7d901150bd3d0789d50c46f365b058f2f5f1f52dis the mergeddashpay/dash-selfhosted-imagemain revision containing both dashpay/dash-selfhosted-image#7 and dashpay/dash-selfhosted-image#8. It retains the validated full/AMD64NDK_VERSION/CMDLINE_VERSIONaliases while using paginated full commit statuses incandidate_digest, selecting the newest logical context before checking creator, publisher workflow and immutable digest provenance.Related Platform changes: #5155 (previous compatibility pin) and #5156 (merged full-status runner selector).
What was done?
Updated only the two trusted controller references in
.github/workflows/runner-image-candidate.ymlto the same exact integrated SHA:jobs.image.uses.jobs.image.with.control_revision.All other file bytes are unchanged, including permissions, secret names, concurrency and event gates. No manifest, recipe, image, application/runtime, runner-service, configuration or credential changes. No manual workflow dispatch, PR merge, or changes to PR #5151.
Host deployment is handled separately by the parent/host owner using the same integrated SHA. This PR does not deploy or claim activation of the host controller.
Requested reviewer:
ktechmidas(review request, not assignment; API result will be reported separately).How Has This Been Tested?
On Linux, from a fresh worktree based on upstream
v4.2-devatb81ed541ac518945c602618366d1e67f143a25f6:PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/scripts/tests -v— 33 tests passed.actionlint1.7.12 on.github/workflows/runner-image-candidate.yml— passed.git diff --check— passed; self-reviewed the complete two-line diff.7d901150bd3d0789d50c46f365b058f2f5f1f52d; verified merged legacy PR feat(wallet-lib): do not sync transactions if mnemonic is absent #7 (27c1666), CPU PR docs(sdk): provide getTransactionHistory #5 (92fcca1) and documentation PR build(sdk): upgrade to webpack 5 #6 (6eee512) are ancestors.test_legacy_template_compat.py— 6 tests passed, including pinned legacy materialization with the known-good rendered hash and fail-closed unsupported/unknown placeholders.test_candidate_status.py— 13 tests passed, covering captured API provenance, pagination, newest-status shadowing, malformed creators, and publisher/digest gates.These are focused local checks, not claims of full image builds, application tests or host activation.
Breaking Changes
None. Only the paired trusted controller revision pins change.
Checklist:
structure.rs, regeneratedgrovedb-structure.json, and checked the structure viewer link posted on this pull requestExisting tests were rerun; this pin-only change requires no new code comments, tests, documentation or GroveDB changes.
For repository code-owners and collaborators only
PR Hygiene ·
c4493d5/skip-botsproceeds without the ones not yet reported.github/workflows/runner-image-candidate.yml) — QuantumExplorer or shumkovWhen every box is checked the
PR Hygienecheck passes and this can merge.