-
Notifications
You must be signed in to change notification settings - Fork 14
feat: abstract BLS backend types behind newtypes, isolate to dashcore-crypto crate, switch to dash-pkc from blsful fork
#1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fc564af
refactor(dash)!: drop the pre-1.48 fallbacks voided by MSRV 1.89
kwvg a7844d7
refactor(dash)!: generate BLS types with `dash_types::make_bytes!`
kwvg 61475b5
refactor(dash): condense BLS type conversion w/ `dash_types::type_cvrt!`
kwvg ac0f7ec
refactor(dash): split out BLS-specific errors to `BlsError` enum
kwvg e9fd825
feat: introduce the `dashcore-crypto` crate, migrate BLS crypto
kwvg 2707c78
refactor!: isolate the backend's BLS public key type with a newtype
kwvg 1f37922
refactor!: isolate the backend's BLS secret key type with a newtype
kwvg 4cc28d5
refactor(key-wallet)!: restrict `private_key`, propagate BLS errors
kwvg c00aeec
refactor!: isolate the backend's BLS signature type with a newtype
kwvg 63cf020
refactor: move BLS compatibility tests to `dashcore-crypto`
kwvg 26a37cd
test(crypto): deduplicate BLS test vectors
kwvg 384cf16
feat(crypto)!: switch BLS backend to `dash-pkc` from `blsful` fork
kwvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| groups: | ||
| core: | ||
| - dashcore | ||
| - dashcore-crypto | ||
| - dashcore_hashes | ||
| - dashcore-private | ||
| - dash-network | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| [package] | ||
| name = "dashcore-crypto" | ||
| version = { workspace = true } | ||
| authors = ["The Dash Core Developers"] | ||
| license = "CC0-1.0" | ||
| repository = "https://github.com/dashpay/rust-dashcore/" | ||
| description = "Cryptographic primitives shared by rust-dashcore crates." | ||
| categories = ["cryptography::cryptocurrencies"] | ||
| keywords = ["crypto", "dash", "bls"] | ||
| edition = "2021" | ||
|
|
||
| [features] | ||
| default = [] | ||
|
|
||
| bincode = ["dep:bincode", "dep:bincode_derive", "dashcore_hashes/bincode"] | ||
| bls = ["dep:dash-pkc", "dep:tracing"] | ||
| serde = ["dep:serde", "dash-types/serde", "dashcore_hashes/serde"] | ||
|
|
||
| [dependencies] | ||
| bincode = { workspace = true, optional = true } | ||
| bincode_derive = { workspace = true, optional = true } | ||
| dash-pkc = { version = "=0.1.0-beta", default-features = false, features = ["bls", "std"], optional = true } | ||
| dash-types = { version = "=0.1.0-beta", default-features = false, features = ["codec"] } | ||
| dashcore_hashes = { path = "../hashes" } | ||
| hex = { version = "0.4" } | ||
| internals = { path = "../internals", package = "dashcore-private" } | ||
| serde = { version = "1.0.219", default-features = false, features = [ "derive", "alloc" ], optional = true } | ||
| thiserror = "2" | ||
| tracing = { version = "0.1", optional = true } | ||
|
|
||
| [lints.rust] | ||
| unexpected_cfgs = { level = "deny", check-cfg = ['cfg(bench)', 'cfg(fuzzing)', 'cfg(kani)'] } | ||
|
|
||
| [dev-dependencies] | ||
| hex_lit = { version = "0.1.1", features = ["rust_v_1_46"] } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.