fix: harden tracker and uptime delivery - #585
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The latest updates on your projects. Learn more about Unkey Deploy
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
Greptile SummaryThis PR makes uptime event delivery durable through a checkpointed BullMQ relay and acknowledged Kafka sends, refreshes scheduler retry options, adds replay-aware reporting queries, and bounds tracker pixel retries and cancellation.
Confidence Score: 4/5The reporting deduplication should be corrected before merging because it can discard distinct uptime checks that happen to have identical stored values. The new event ID provides a unique probe identity only until ingestion, where it is dropped; downstream queries consequently deduplicate by mutable observation values and cannot distinguish an exact replay from two genuinely separate identical probes. Files Needing Attention: packages/ai/src/query/builders/uptime.ts and packages/rpc/src/routers/status-page.ts Important Files Changed
Sequence DiagramsequenceDiagram
participant S as BullMQ source job
participant P as Uptime probe
participant D as BullMQ delivery queue
participant K as Kafka
participant V as Vector
participant C as ClickHouse
S->>P: Run probe
P-->>S: UptimeData with event_id
S->>S: Checkpoint event in job data
S->>D: Add deterministic delivery job
D->>K: Send with all-replica acknowledgement
K->>V: analytics-uptime-checks
V->>C: Insert known uptime columns
Note over V,C: event_id is dropped
C-->>C: Reporting applies value-based LIMIT 1 BY
Reviews (1): Last reviewed commit: "fix(uptime): durably relay completed che..." | Re-trigger Greptile |
992cea4 to
ae0e935
Compare
Summary
Scope
Clean replacement for #581 on current
staging. It intentionally excludes that branch's stale Basket and Vector changes.Verification
bun run lintbun run check-types