Skip to content

style(basket): fix structured-errors formatting to unblock release lint - #591

Merged
izadoesdev merged 1 commit into
stagingfrom
izadoesdev/basket-lint-fix
Aug 4, 2026
Merged

style(basket): fix structured-errors formatting to unblock release lint#591
izadoesdev merged 1 commit into
stagingfrom
izadoesdev/basket-lint-fix

Conversation

@izadoesdev

@izadoesdev izadoesdev commented Aug 4, 2026

Copy link
Copy Markdown
Member

The defineErrorCatalog("basket", BASKET_ERROR_SPEC) call from #590 was a single line; ultracite wants it wrapped multi-line. This failed the Lint check on staging and is blocking the staging→main release (#587). Verified: bunx ultracite check clean.


Summary by cubic

Wrap the defineErrorCatalog("basket", BASKET_ERROR_SPEC) call over multiple lines to satisfy ultracite formatting and fix the failing Lint check on staging. This unblocks the staging→main release.

Written for commit 4078a65. Summary will update on new commits.

Review in cubic

@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
databuddy-status Ready Ready Preview Aug 4, 2026 12:29pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
dashboard Skipped Skipped Aug 4, 2026 12:29pm
documentation Skipped Skipped Aug 4, 2026 12:29pm

@vercel
vercel Bot temporarily deployed to Preview – documentation August 4, 2026 12:29 Inactive
@vercel
vercel Bot temporarily deployed to Preview – dashboard August 4, 2026 12:29 Inactive
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7c946d61-e586-4732-aa00-0508ee57e748

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@izadoesdev
izadoesdev merged commit ade008d into staging Aug 4, 2026
17 of 18 checks passed
@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about Databuddy Add Dosu to your team

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR reformats the basket error-catalog initialization to satisfy Ultracite without changing runtime behavior.

  • Wraps the existing defineErrorCatalog call across multiple lines.
  • Preserves the original namespace and error-spec arguments.

Confidence Score: 5/5

The PR appears safe to merge because it only reformats an existing function call without changing its arguments or behavior.

The exported error catalog is still initialized with the same function, namespace, and specification object, so no runtime contract or control flow changes.

Important Files Changed

Filename Overview
apps/basket/src/lib/structured-errors.ts Formatting-only change preserves the error catalog call and introduces no functional issues.

Reviews (1): Last reviewed commit: "style(basket): wrap defineErrorCatalog c..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant