chore(repo): catch formatting in pre-commit before CI - #592
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
|
The latest updates on your projects. Learn more about Unkey Deploy
|
Greptile SummaryThe PR adds an Ultracite check for staged source and configuration files to the pre-commit hook, allowing formatting and lint failures to surface before CI.
Confidence Score: 5/5The PR appears safe to merge, with the new hook using the repository’s existing pinned Ultracite tooling. The added command applies the same Ultracite check used by CI to relevant staged files, and no concrete build, hook-execution, or coverage failure remains. Important Files Changed
Reviews (1): Last reviewed commit: "chore(repo): run ultracite check in pre-..." | Re-trigger Greptile |
The pre-commit hook ran check-types and policy-lint but never
ultracite check, so formatting issues (like the #590 one-liner that failed the release lint on #587) only surfaced in CI. Adds a staged-fileultracite checkstep to lefthook's pre-commit, mirroring CI'sLintjob.Verified: staged a misformatted file and ran
bunx lefthook run pre-commit— the newformatcommand fails withRun: bun run format; clean files pass.Summary by cubic
Add
ultraciteformatting checks tolefthookpre-commit so formatting issues are caught locally instead of failing in CI. The hook runsbunx ultracite check {staged_files}across JS/TS/JSON/CSS and fails with “Run: bun run format” to guide fixes.Written for commit 33836f3. Summary will update on new commits.