ci: pin Nix releases from release-plz - #103
Merged
Merged
Conversation
The pin job never ran. The tag `ringo-phone-v0.15.0` sits on a commit that does contain the trigger, but release-plz tags with the default GITHUB_TOKEN, and GitHub does not fire workflows for events that token creates — the same reason the binary, Docker and docs jobs already hang off release-plz instead of a tag trigger. It is written down in release-plz.yml; I added the tag trigger anyway. So the pin becomes a reusable workflow taking the two tags as inputs, the way homebrew.yml does, and release-plz calls it when either crate was released. nix-cache.yml goes back to what a push trigger can actually do: fill the cache from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin job added in #102 never ran: release-plz tags with the default
GITHUB_TOKEN, and GitHub does not fire workflows for events that tokencreates.
release-plz.yml:139already says so — it is why the binary, Dockerand docs jobs are called from there rather than triggered by the tag.
The pin is now a reusable workflow taking the two tags as inputs, called from
release-plz like
homebrew.yml.nix-cache.ymlkeeps only what a push triggercan do: fill the cache from main.