feat: add grambow barrier heights benchmark - #670
Open
lwehrhan wants to merge 5 commits into
Open
Conversation
ElliottKasoar
added
the
new benchmark
joehart2001
reviewed
Jul 9, 2026
Collaborator
|
Thanks for the pr! same as #658 could you send the data + have a look at the element filtering? docs: https://ddmms.github.io/ml-peg/developer_guide/filter.html |
lwehrhan
marked this pull request as ready for review
July 23, 2026 23:04
joehart2001
force-pushed
the
feat/add-grambow-reactivity-benchmark
branch
from
July 28, 2026 12:38
cd4691d to
9317dfa
Compare
Collaborator
|
Hey, im pretty happy with your side of the code. ive added the structure vis here too, but there are some minor bugs regarding the point highlighting during structure vis which i need to look into. otherwise all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
The Grambow dataset of reaction comprises about 12,000 reactant/product/transition state triplets for reactions of small neutral organic molecules limited to the elements H, C, N and O, accompanied by energy labels at ωB97X-D3/def2-TZVP level of theory. This benchmark assesses if the MLIP can accurately predict the barrier heights of all reactions across the full dataset. Reaction energies are also reported, however the benchmark is specifically targeted at barrier heights.
Linked issue
Resolves #662
Progress
Testing
New decorators/callbacks