Skip to content

Add framework summary tables on each page + overall framework summary - #751

Open
joehart2001 wants to merge 4 commits into
mainfrom
framework-summary
Open

Add framework summary tables on each page + overall framework summary#751
joehart2001 wants to merge 4 commits into
mainfrom
framework-summary

Conversation

@joehart2001

Copy link
Copy Markdown
Collaborator

… on main page

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

  • I've confirmed the contribution guidelines.
  • I have reviewed and understand all AI-generated code in this PR.
  • I have added human-written tests for the new logic.
  • I have properly cited any upstream algorithms or libraries the AI utilized.
  • I have disclosed significant AI tool usage in the PR description.

Summary

  • framework table on each framework page which collects all the framework tests
  • summary framework table on main page, collecting all frameworks
  • have tested updating weights and thresholds and score propagation seems to be working as expected
  • dedicated build framework file to reduce bloat again
  • claude code for review, fixing precommit and bug finding

Linked issue

Resolves #

Testing

Comment thread ml_peg/app/utils/build_frameworks.py Outdated
Comment thread ml_peg/app/utils/build_frameworks.py Outdated
Comment thread ml_peg/app/utils/build_frameworks.py Outdated
Comment thread ml_peg/app/utils/build_frameworks.py Outdated
@ElliottKasoar ElliottKasoar added the enhancement New feature or request label Jul 27, 2026
@ElliottKasoar ElliottKasoar linked an issue Jul 27, 2026 that may be closed by this pull request

from __future__ import annotations

from typing import NotRequired, TypedDict

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think NotRequired may only have been added in 3.11 so we may not be able to do this while supporting 3.10

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this not be caught by the ci tests or not?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally yes, but I don't think currently - none of the CI currently attempts to build the app. I just tried with 3.10 and I do get:

ImportError: cannot import name 'NotRequired' from 'typing' (/Users/elliottkasoar/.local/share/uv/python/cpython-3.10.16-macos-aarch64-none/lib/python3.10/typing.py)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add summary tables for frameworks

2 participants