feat: sunset scene editor create/edit and redirect editor routes - #3488
feat: sunset scene editor create/edit and redirect editor routes#3488cyaiox wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report for CI Build 33640786636Coverage increased (+0.3%) to 54.039%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
decentraland-bot
left a comment
decentraland-bot
left a comment
There was a problem hiding this comment.
✅ Review — Approve
Clean, focused sunset PR that removes scene editor create/edit functionality and gracefully redirects old routes to the scene list.
What this PR does
- SceneDetailPage: Removes the project-rename edit icon and the "Edit Scene" button, along with their
handleEditClickandhandleEditScenecallbacks - ScenesPage: Removes the
SceneCreationSelectorcomponent (scene creation entry point) - AppRoutes: Removes lazy imports and
<Route>entries forEditorPage,InspectorPage,TemplatesPage,TemplateDetailPage; adds<Redirect>entries pointing all four sunset routes to/scenes - AppRoutes.spec.tsx: New test validating all four redirects using
it.eachwith concrete IDs
Findings
No P0 or P1 issues found.
[P2] Branch naming (ADR-6): Branch sunset/1-behavior-sunset uses a non-standard prefix. ADR-6 expects (chore|docs|feat|fix|refactor|style|test)/<summary>. Something like feat/sunset-scene-editor would be more conventional. Not blocking — the PR title feat: sunset scene editor create/edit and redirect editor routes follows the semantic commit format correctly, and that becomes the squash commit message.
[P2] Test cleanup — window.innerWidth not restored: The test sets window.innerWidth = 1280 in beforeEach but doesn't restore the original value in an afterEach. Minor issue since it's the only describe block today, but good hygiene for a test file likely to grow.
[P2] Dead component files (expected in stack): EditorPage, InspectorPage, TemplatesPage, TemplateDetailPage, and SceneCreationSelector are no longer imported/routed but their source files still exist. This is expected for a stacked PR series (noted in the PR body) — just confirming these should be cleaned up in a subsequent PR in the stack.
Security review
No security issues found. The redirects use hardcoded internal paths (no user-controlled redirect targets), landing on a ProtectedRoute — no open redirect, auth bypass, or injection risk. No secrets or sensitive data in the diff.
Consumer impact
No public API surface changed. This is a purely frontend UI/routing change within the builder app. No downstream consumers affected.
CI status
All checks passing ✅ (audit, test, Vercel preview deployed)
Routing verification
Confirmed via locations.ts that the no-arg forms return proper React Router patterns (/scene-editor/:projectId, /inspector/:projectId, /templates, /templates/:templateId). The <Redirect from> entries inside <Switch> correctly match parameterized paths and redirect to /scenes. Placement is correct — after all real routes, before the catch-all <Redirect to={locations.root()} />.
Reviewed by Jarvis 🤖 · Requested by Gabriel Díaz (<@U03MGHMAJL8>) via Slack
Remove the create-scene selector, the edit-scene button, and the title rename affordance. Hard-block the editor and template routes by redirecting them to the scene list. Download, delete, and unpublish stay.
122a22b to
f88939b
Compare
3 participants
Feature Description
First layer of the web scene editor sunset. The web builder no longer lets users create or edit scenes — creators move to the desktop Creator Hub (the in-app
CreatorHubUpgradeModalalready points there). This PR removes the create/edit entry points from the UI and hard-blocks the editor and template routes so bookmarked or pasted URLs can't reach them either. Downloading, deleting, and unpublishing scenes are unaffected.User Story
As a Decentraland creator, I can no longer create or edit scenes in the web builder (that capability moves to Creator Hub), but my existing scenes stay visible and their detail pages remain accessible so I can still download, unpublish, or delete them.
Type of Change
Implementation Details
Bottom of the sunset stack (base:
master). Purely UI + routing; no data or redux changes.Architecture
The editor/template routes are removed from the desktop
<Switch>inAppRoutesand replaced with<Redirect>s tolocations.scenes(), placed before the catch-all so old URLs land on the scene list rather than the home page. The create/edit affordances are removed from the two pages that hosted them.Key Files Changed
src/routing/AppRoutes/AppRoutes.tsxEditorPage/InspectorPage/TemplatesPage/TemplateDetailPageroutes + lazy imports; add redirects for/scene-editor,/inspector,/templates,/templates/:id→/scenessrc/components/ScenesPage/ScenesPage.tsxsrc/components/SceneDetailPage/SceneDetailPage.tsxEditProjectModal); keep Download, Delete, Unpublish, deploymentssrc/routing/AppRoutes/AppRoutes.spec.tsx/scenesAPI Changes
No API changes.
Database Changes
How to Test
/scenes— the "create from scratch / from template" tiles are gone; the Creator Hub upgrade modal still opens./scenes/:id— no "Edit scene" button and no title pencil; Download, Delete, and Unpublish are still present and work./scene-editor/<id>,/inspector/<id>,/templates,/templates/<id>— each redirects to/scenes.Edge Cases Considered
:projectId/:templateIdparams) redirect rather than 404 or fall through to the home page.Checklist
Feature Flag
Related Issues
Part of the web scene editor sunset stack. Base branch:
master. Followed by the viewer/Unity removal, inspector removal, migrate-on-download, and dead-code sweep.Screenshots / Demo
UI removals + redirects; no new surface to show.
Deployment Notes
None.