fix: use theme rarities palette for CatalogCard image background - #475
Open
eordano wants to merge 1 commit into
Open
fix: use theme rarities palette for CatalogCard image background#475eordano wants to merge 1 commit into
eordano wants to merge 1 commit into
Conversation
Deploying ui2 with
|
| Latest commit: |
74832e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fba74be1.ui2-423.pages.dev |
| Branch Preview URL: | https://minifix-aug30.ui2-423.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CatalogCard's image background usedRarity.getColor()from@dcl/schemas— the 2021 palette — whileRarityBadgeon the same card readstheme.palette.rarities(the current Figma palette, the reference pattern per CLAUDE.md §6). Same rarity, two colors on one card (common:#ABC1C1vs#73D3D3). The background now reads the theme palette, matching RarityBadge.Known leftover: the
subduedRaritychip variant (CatalogRarityChip) still derives from the schemas colors and carries a comment calling schemas the source of truth — a follow-up issue covers migrating it totheme.palette.rarities/raritiesTextand resolving the comment/CLAUDE.md contradiction.