fix: pin @decocms/start to Host-preserving fallback proxy (deco-start#308) - #41
Open
hugo-ccabral wants to merge 1 commit into
Open
fix: pin @decocms/start to Host-preserving fallback proxy (deco-start#308)#41hugo-ccabral wants to merge 1 commit into
hugo-ccabral wants to merge 1 commit into
Conversation
Points @decocms/start at decocms/deco-start#b5b313e (PR #308), which makes proxyToFallback forward the original Host header instead of dropping it. The EKS ingress LB (fallbackOrigin) routes by Host, so without it every fallback-bucket request on storefront.deco.site returned the origin's 404. Revert to a published version once deco-start PR #308 is released. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
storefront-tanstack | d28d767 | Commit Preview URL Branch Preview URL |
Jul 06 2026, 08:09 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
storefront.deco.sitereturns 404 on every request. The A/B wrapper works as configured (SITES_KV→ratio: 0→ 100% fallback bucket), butproxyToFallbackin@decocms/startdrops the incomingHostheader, so the EKS ingress LB receivesHost: <fallbackOrigin>and can't route to the site — it answers with its own 404, which the worker relays (x-deco-bucket: fallback).Fix
Pins
@decocms/startto decocms/deco-start#308 (commitb5b313e), which forwardsHost: <site hostname>on the fallback proxy — same behavior as the original cf-dispatch gateway.Temporary pin: revert to a published
^6.xversion once deco-start #308 is merged and released.Testing
bun run buildpasses; built worker bundle contains the Host-preserving proxy (set(\"host\", url.hostname))curl -i https://storefront.deco.site/ curl -i -H "Host: storefront.deco.site" https://decoserverless.deco.site/🤖 Generated with Claude Code