Skip to content

Include visitors in A/B goals chart #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitavano merged 1 commit into from
Jul 8, 2026
Merged

Include visitors in A/B goals chart #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions web/tools/experiments/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,8 @@ function ResultsView({
callTool,
]);

// Tables (Funnel / By Goal) show every goal including the visitors baseline,
// matching the admin. The bar chart drops visitors (its conversion would
// always be 100% and would flatten the other goals).
// Every goal, visitors baseline included — used by the tables and the chart,
// matching the admin.
const sortedGoals = useMemo(
() => (data ? sortByTotal(data.goals) : []),
[data],
Expand Down Expand Up @@ -418,13 +417,11 @@ function ResultsView({
"Test Variant 1": point.variant,
})) ?? [];

const barData = sortedGoals
.filter((g) => g.goal !== "visitors")
.map((g) => ({
goal: g.goal,
Default: percentage(g.default, visitors.default),
"Test Variant 1": percentage(g.variant, visitors.variant),
}));
const barData = sortedGoals.map((g) => ({
goal: g.goal,
Default: percentage(g.default, visitors.default),
"Test Variant 1": percentage(g.variant, visitors.variant),
}));

return (
<div className="flex flex-col gap-6">
Expand Down
Loading