Skip to content

fix(vtex/plp): type productListingPage return as ProductListingPage #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guitavano wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(vtex/plp): type productListingPage return as ProductListingPage #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions vtex/inline-loaders/productListingPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
} from "../client";
import { pickSku, toProduct } from "../utils/transform";
import type { Product as ProductVTEX, Sort } from "../utils/types";
import type { ProductListingPage } from "../../commerce/types/commerce";

export interface SelectedFacet {
key: string;
Expand Down Expand Up @@ -244,12 +245,13 @@ function pageTypesToBreadcrumb(pageTypes: PageType[]) {

// -- SEO from page types (mirrors original pageTypesToSeo) --

function pageTypesToSeo(pageTypes: PageType[]) {
function pageTypesToSeo(pageTypes: PageType[]): ProductListingPage["seo"] {
const current = pageTypes[pageTypes.length - 1];
if (!current) return undefined;
return {
title: current.title || current.name || "",
description: current.metaTagDescription || "",
canonical: "",
};
}

Expand Down Expand Up @@ -321,7 +323,7 @@ function isValidPLPPath(path: string): boolean {
* 4. Transform facets to FilterToggle format
* 5. Build pagination from IS response
*/
export default async function vtexProductListingPage(props: PLPProps): Promise<any | null> {
export default async function vtexProductListingPage(props: PLPProps): Promise<ProductListingPage | null> {
const pageUrl = props.__pageUrl ? new URL(props.__pageUrl, "https://localhost") : null;

const query = props.query ?? pageUrl?.searchParams.get("q") ?? "";
Expand Down
Loading