fix(shopify): drop "shopify" token from OAuth URLs - #541
Merged
Conversation
Shopify forbids the word "shopify" in app URLs. Rename the OAuth callback path and point the MCP at a neutral host: - callback path /oauth/shopify/callback -> /oauth/store/callback (not /oauth/callback, which the runtime mounts on this origin) - host sites-shopify.deco.site -> mcp-commerce-store.deco.site (app.json connection.url + DEFAULT_SELF_URL) Follow-ups (external): map mcp-commerce-store.deco.site to the service and register the new redirect_uri in the Shopify Partners app. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Shopify forbids the word "shopify" in an app's URLs (callback + host). The Shopify MCP's OAuth flow used it in both:
…/oauth/shopify/callbacksites-shopify.deco.siteWhat
/oauth/shopify/callback→/oauth/store/callback/oauth/callback— that path is where the runtime mounts its own OAuth callback on this same origin, so it would collide.sites-shopify.deco.site→mcp-commerce-store.deco.siteapp.jsonconnection.url+DEFAULT_SELF_URLinoauth.ts.The connect page (
/oauth/custom) was already clean.Follow-ups (external, not in this PR)
mcp-commerce-store.deco.siteat the service. The platform's automatic domain issites-<site>.deco.site, so this host needs a custom-domain mapping (thedeploy.jsonsitefield is left asshopify— it's just the internal deploy identity and isn't merchant-facing).https://mcp-commerce-store.deco.site/oauth/store/callbackin the app's redirect allowlist.🤖 Generated with Claude Code
Summary by cubic
Removes "shopify" from public OAuth URLs to comply with Shopify’s URL policy. Callback path changes from /oauth/shopify/callback to /oauth/store/callback, and the default public origin changes from https://sites-shopify.deco.site to https://mcp-commerce-store.deco.site;
app.jsonandregistry.jsonnow point to the new host.Written for commit 8fff1eb. Summary will update on new commits.