chore(cli): remove dead --prune/-e flags from parseArgs - #6163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop
linkfeature (the only consumer of--pruneand-e/--env) was removed in #5570 ("chore(link): remove the desktop link feature"), but that PR left the two flag definitions dangling inapps/api/src/cli.ts'sparseArgsoptions — they're accepted on the command line but never read anywhere (values.prune/values.envhave zero references), and neither appears in the--helpoutput.A maintainer wants this because dead CLI flags are misleading: they silently accept
--prune/-e <value>and do nothing, which is confusing for anyone poking atdeco --helpor grepping the source for what a flag does.Net change: -5 lines, 0 added. Confirmed dead via
grep -rn "values\.prune\|values\.env" apps/api/src/(no hits) and by reading the git history ofcli.tsback to the commit that introduced them for thelinkcommand.A reviewer can confirm with:
(no matches after this change) and
cd apps/api && bunx tsc --noEmit.Locally verified:
bun run fmt,cd apps/api && bunx tsc --noEmit(clean),bunx oxlint src/cli.ts(0 warnings/errors). No test exercises these flags (there's nocli.test.ts), so this is a pure dead-code deletion — full CI validates the rest.Summary by cubic
Removes the unused CLI flags
--pruneand-e/--envfromapps/api/src/cli.ts’sparseArgs. These flags belonged to the removed desktop link feature; they were previously accepted but no-ops and are now unrecognized to prevent confusion.cli.ts; typecheck remains clean.Written for commit 1e8b3b0. Summary will update on new commits.