fix(previews): bump to 0.1.1 so namespaceLabels actually ships - #6214
Merged
Conversation
#6213 added namespaceLabels to the ApplicationSet template but only bumped the studio chart. release-sandbox-charts.yaml skips the push when the version is already published — correctly, since OCI tags should be immutable — so 0.1.0 in the registry is still the version without it. Without this the preview's Namespace renders with no gateway selector label and the HTTPRoute attaches to nothing: a 404 with a green Argo, which is the exact failure #6213 set out to make impossible.
… passes The Namespace assertion added alongside the chart change reported exactly the condition it was written for — a namespace with no gateway selector label — but against the test render rather than a real one, because the step never supplied preview.namespaceLabels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6213 added
namespaceLabelsto the ApplicationSet template but bumped only the studio chart.release-sandbox-charts.yamlchecks whether the version is already published and skips the push if so — correct behaviour, OCI tags should be immutable — sochart-deco-studio-previews:0.1.0in the registry is still the build without it:Why it matters
chart-deco-studio0.14.3 renders the preview Namespace itself, withpreview.namespaceLabelssupplying the label the Gateway admits routes by. If the ApplicationSet never passes that value, the namespace renders without the label and the HTTPRoute attaches to nothing — a 404 with a green Argo, which is precisely the failure #6213 exists to remove.managedNamespaceMetadatastill labels the namespace on the first sync, so this is not guaranteed to break — but it makes correctness depend on apply ordering between two writers of the same object, which is not something to rely on.Rollout
Publishing 0.1.1 is not enough on its own:
apps/studio-preview/values.yamlindecocms/deco-apps-cdpinschart-deco-studio-previews, and also still pinsstudioChart.version: "0.14.1"— two versions behind. Both need bumping there before any of this reaches a preview.Summary by cubic
Publishes
namespaceLabelsby bumpingchart-deco-studio-previewsto 0.1.1 and fixes CI to render previews with those labels. Previously 0.1.0 omitted the field (immutable tag), so preview Namespaces lacked the gateway selector label and HTTPRoutes attached to nothing; now labels flow tochart-deco-studio0.14.3 which renders the Namespace with the selector, removing reliance onmanagedNamespaceMetadataordering. CI Helm template now setspreview.namespaceLabelsso the namespace assertion validates a real render.decocms/deco-apps-cdapps/studio-preview/values.yaml: setchart-deco-studio-previews.version: "0.1.1"andstudioChart.version: "0.14.3".Written for commit f74e037. Summary will update on new commits.