Skip to content

fix(previews): bump to 0.1.1 so namespaceLabels actually ships - #6214

Merged
nicacioliveira merged 2 commits into
mainfrom
fix/previews-chart-bump
Aug 19, 2026
Merged

fix(previews): bump to 0.1.1 so namespaceLabels actually ships#6214
nicacioliveira merged 2 commits into
mainfrom
fix/previews-chart-bump

Conversation

@nicacioliveira

@nicacioliveira nicacioliveira commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

#6213 added namespaceLabels to the ApplicationSet template but bumped only the studio chart. release-sandbox-charts.yaml checks whether the version is already published and skips the push if so — correct behaviour, OCI tags should be immutable — so chart-deco-studio-previews:0.1.0 in the registry is still the build without it:

$ helm pull chart-deco-studio-previews --version 0.1.0
$ grep -c namespaceLabels templates/applicationset.yaml
0

Why it matters

chart-deco-studio 0.14.3 renders the preview Namespace itself, with preview.namespaceLabels supplying the label the Gateway admits routes by. If the ApplicationSet never passes that value, the namespace renders without the label and the HTTPRoute attaches to nothing — a 404 with a green Argo, which is precisely the failure #6213 exists to remove.

managedNamespaceMetadata still labels the namespace on the first sync, so this is not guaranteed to break — but it makes correctness depend on apply ordering between two writers of the same object, which is not something to rely on.

Rollout

Publishing 0.1.1 is not enough on its own: apps/studio-preview/values.yaml in decocms/deco-apps-cd pins chart-deco-studio-previews, and also still pins studioChart.version: "0.14.1" — two versions behind. Both need bumping there before any of this reaches a preview.


Summary by cubic

Publishes namespaceLabels by bumping chart-deco-studio-previews to 0.1.1 and fixes CI to render previews with those labels. Previously 0.1.0 omitted the field (immutable tag), so preview Namespaces lacked the gateway selector label and HTTPRoutes attached to nothing; now labels flow to chart-deco-studio 0.14.3 which renders the Namespace with the selector, removing reliance on managedNamespaceMetadata ordering. CI Helm template now sets preview.namespaceLabels so the namespace assertion validates a real render.

  • Rollout
    • Update decocms/deco-apps-cd apps/studio-preview/values.yaml: set chart-deco-studio-previews.version: "0.1.1" and studioChart.version: "0.14.3".
    • After deploy, verify a preview Namespace has the gateway selector label and routes resolve.

Written for commit f74e037. Summary will update on new commits.

Review in cubic

#6213 added namespaceLabels to the ApplicationSet template but only bumped the
studio chart. release-sandbox-charts.yaml skips the push when the version is
already published — correctly, since OCI tags should be immutable — so 0.1.0 in
the registry is still the version without it.

Without this the preview's Namespace renders with no gateway selector label and
the HTTPRoute attaches to nothing: a 404 with a green Argo, which is the exact
failure #6213 set out to make impossible.
… passes

The Namespace assertion added alongside the chart change reported exactly the
condition it was written for — a namespace with no gateway selector label — but
against the test render rather than a real one, because the step never supplied
preview.namespaceLabels.
@nicacioliveira
nicacioliveira merged commit 2a4c2a2 into main Aug 19, 2026
31 checks passed
@nicacioliveira
nicacioliveira deleted the fix/previews-chart-bump branch August 19, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant