Skip to content

feat(assets): make the native Assets tab always-on, drop the feature flag - #6262

Merged
guitavano merged 3 commits into
mainfrom
guitavano/assets-tab-remove-flag
Aug 19, 2026
Merged

feat(assets): make the native Assets tab always-on, drop the feature flag#6262
guitavano merged 3 commits into
mainfrom
guitavano/assets-tab-remove-flag

Conversation

@guitavano

@guitavano guitavano commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the native_assets_tab feature flag and makes the native per-site Assets tab always-on. The external admin-MCP assets UI is being removed (decocms/admin-mcp#30), so the native tab is now the assets experience — no reason to keep it gated.

  • use-main-panel-tabs.ts: the Assets tab shows whenever an S3 bucket is associated to the site's siteSlug (matchSiteSlugConfig), dropping the flag gate. The ?main=assets fallback guard stays (falls back to default when no bucket).
  • OrgFlagsSchema: removed native_assets_tab; regenerated tool contracts.
  • Navigation settings: removed the toggle (added in feat(settings): add Native Assets tab toggle in navigation settings #6257) + its en/pt-br i18n keys.

Context / sequencing

Builds on #6251 (native tab + flag) and #6257 (settings toggle), both merged. Pairs with decocms/admin-mcp#30 (removes the fetch_assets UI). Net effect once all land: every site with an associated bucket gets the native Assets tab; nothing to toggle.

Still open as a follow-up: Studio import (import-from-deco-dialog.tsx) currently creates the fetch_assets pinned view on deco.cx import — that becomes a no-op tab once admin-mcp#30 ships and should be dropped separately.

Testing notes

  • tsc --noEmit passes (shared / web / api); oxlint clean on touched files; bun run fmt applied. No remaining references to native_assets_tab.

🤖 Generated with Claude Code


Summary by cubic

Makes the per-site Assets tab always-on when a site has an associated S3 bucket and removes the native_assets_tab feature flag and settings toggle. Replaces the admin-MCP fetch_assets view: we no longer pin it on import and we skip existing fetch_assets pins at render, so users see the native tab instead. The ?main=assets fallback still drops to the default tab if no bucket is configured.

Review and rollout

Written for commit 8f4cf9c. Summary will update on new commits.

Review in cubic

…flag

The external admin-MCP assets UI is being removed (decocms/admin-mcp#30), so
the native per-site Assets tab is now the assets experience — no longer gated.

- use-main-panel-tabs: show the Assets tab whenever a bucket is associated to
  the site's slug, dropping the `native_assets_tab` gate.
- Remove `native_assets_tab` from OrgFlagsSchema + its Navigation settings
  toggle and i18n; regenerate tool contracts.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added the claude PR authored by a coding agent label Aug 19, 2026
guitavano and others added 2 commits August 19, 2026 15:10
…mport

The native always-on Assets tab replaces the admin-MCP assets view, so the
deco.cx import no longer pins `fetch_assets`. The Monitor pinned view
(get_monitor_data) stays — admin-MCP still serves it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…sites

admin-MCP no longer serves fetch_assets (decocms/admin-mcp#30), so sites
imported before this change carry a dead "Assets" pinned view. Skip it at
render time — the native always-on Assets tab replaces it — so no data
migration is needed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@guitavano
guitavano merged commit 92a047f into main Aug 19, 2026
35 of 36 checks passed
@guitavano
guitavano deleted the guitavano/assets-tab-remove-flag branch August 19, 2026 18:40
decocms Bot pushed a commit that referenced this pull request Aug 19, 2026
PR: #6262 feat(assets): make the native Assets tab always-on, drop the feature flag
Bump type: minor

- decocms (apps/api/package.json): 4.235.4 -> 4.236.0
- @decocms/native (apps/native/package.json): 4.235.4 -> 4.236.0
- @decocms/shared (packages/shared/package.json): 0.43.0 -> 0.44.0

Deploy-Scope: web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude PR authored by a coding agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant