feat: DH-23199: Add loader as a field to JsPlugin - #28
Open
mofojed wants to merge 1 commit into
Open
Conversation
- Add a loader field which can contain JSON data for loading the plugin
devinrsmith
approved these changes
Jul 30, 2026
Comment on lines
+7
to
+16
| JsonValue = typing.Union[ | ||
| None, | ||
| bool, | ||
| int, | ||
| float, | ||
| str, | ||
| typing.List["JsonValue"], | ||
| typing.Dict[str, "JsonValue"], | ||
| ] | ||
| """A JSON node; any value that can be represented in JSON.""" |
Member
There was a problem hiding this comment.
I don't want to hold up this change, but we might consider bumping our python minimum version here in the future, so we could use the more "modern" (aka 2022) suggestion from python/typing#182 (comment)
JSON: TypeAlias = dict[str, "JSON"] | list["JSON"] | str | int | float | bool | None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loaderdetails from package.json to the manifest.json deephaven-core#8299,