ci: publish sticky benchmark comments - #142
Conversation
Greptile SummaryThis PR adds an isolated
Confidence Score: 4/5The workflow should not be merged until failed or timed-out runs can update the sticky comment even when no comparison artifact was produced. The new job reaches its banner-generation logic only after a mandatory artifact download, while producer timeout and compare-job failure paths can omit that artifact and leave a stale successful comment untouched. Files Needing Attention: .github/workflows/bench-comment.yml
|
| Filename | Overview |
|---|---|
| .github/workflows/bench-comment.yml | Adds the privileged sticky-comment workflow, but its failure-banner path is blocked when the triggering run does not produce an artifact. |
Sequence Diagram
sequenceDiagram
participant B as Bench workflow
participant A as Artifact store
participant C as Bench comment workflow
participant P as Pull request
B->>A: Upload comparison and PR number
B-->>C: workflow_run completed
C->>A: Download artifact by run ID
alt Artifact is available and valid
C->>P: Validate current head SHA
C->>P: Create or update sticky comment
else Artifact was not produced
A-->>C: Download failure
Note over C,P: Warning banner is never published
end
Reviews (1): Last reviewed commit: "ci: publish sticky benchmark comments" | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Closes #139.
What changed
workflow_runworkflowgh api, with serialized writes per PR branchValidation
actionlint .github/workflows/bench-comment.ymlgit diff --checkThe full comment path cannot run until this workflow exists on
main, as noted in #139.Summary by cubic
Adds a
workflow_runworkflow that posts a sticky benchmark comparison comment on pull requests, closing #139. Only benchmark runs triggered by a pull request are considered, so baseline runs are skipped.Benchworkflow.main, as noted in Bench comment: sticky PR upsert via workflow_run #139.Written for commit 3c570dd. Summary will update on new commits.