Skip to content

security: a transfer's memo, ticker and nonce are in no public object (pre-audit item 4) #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cryptskii merged 15 commits into from
Oct 2, 2026
+2,251 −1,223
Merged

security: a transfer's memo, ticker and nonce are in no public object (pre-audit item 4) #1102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3eaf0d8
fix(crypto): SPHINCS+ takes the FIPS 205 structure, BLAKE3 kept (cons…
cryptskii Oct 2, 2026
36a9c2d
test(crypto): each SPHINCS+ role hashes under its own address type
cryptskii Oct 2, 2026
22af3d9
refactor(crypto): the host signs with the shared SPHINCS+ crate; algo…
cryptskii Oct 2, 2026
22d0945
test(core): fixtures name the declared signature algorithm, not a lit…
cryptskii Oct 2, 2026
9ab1d7d
test(core): the vectors construction version 2 moves
cryptskii Oct 2, 2026
015a5ed
docs(security): SPHINCS+ construction version 2 recorded; §6.70
cryptskii Oct 2, 2026
4737a9e
Merge main (#1099) into security/sphincs-structure-repair
claude Oct 2, 2026
544f6ba
WIP: item 4 minimum disclosure — transfer terms by commitment (not pu…
claude Oct 2, 2026
26922f7
WIP: item 4 test fixes (terms on stored BLE sessions; recovery gate b…
claude Oct 2, 2026
d435995
Merge remote-tracking branch 'origin/main' into security/minimum-disc…
claude Oct 2, 2026
73da2a4
item 4: cargo fmt
claude Oct 2, 2026
de67d9d
security: a transfer's memo, ticker and nonce are in no public object…
claude Oct 2, 2026
b211a4c
Repin the 619 intent pins item 4 moved (code only)
claude Oct 2, 2026
e60df85
item 4: no hard-coded or redundant nonce reaches TransferTerms::new
claude Oct 2, 2026
083d30d
Repin the 167 intent pins the nonce fix moved (code only)
claude Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions dsm_client/deterministic_state_machine/dsm/src/bilateral/offline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,14 +603,16 @@ mod tests {
fn bearer_transfer(to: [u8; 32]) -> Operation {
Operation::Transfer {
policy_commit: [0x0F; 32],
terms_commitment: crate::types::operations::TransferTerms {
token_id: b"TOK".to_vec(),
nonce: vec![1; 8],
mode: TransactionMode::Bilateral,
memo: String::new(),
salt: vec![0x5A; 32],
}
.commitment(),
to_device_id: to.to_vec(),
amount: Balance::amount(3),
token_id: b"TOK".to_vec(),
mode: TransactionMode::Bilateral,
nonce: vec![1; 8],
recipient: to.to_vec(),
to: to.to_vec(),
message: String::new(),
signature: Vec::new(),
authority_policy: Some(crate::types::operations::canonical_offline_bearer_policy()),
}
Expand Down
14 changes: 8 additions & 6 deletions dsm_client/deterministic_state_machine/dsm/src/core/bilateral_transaction_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,14 +1026,16 @@ mod tests {
fn signed_transfer_op(kp: &SignatureKeyPair, message: &str, nonce: u8) -> Operation {
let mut op = Operation::Transfer {
policy_commit: [0u8; 32],
token_id: b"ERA".to_vec(),
terms_commitment: crate::types::operations::TransferTerms {
token_id: b"ERA".to_vec(),
nonce: vec![nonce; 8],
mode: TransactionMode::Bilateral,
memo: message.to_string(),
salt: vec![0x5A; 32],
}
.commitment(),
to_device_id: vec![9u8; 32],
amount: Balance::amount(1),
mode: TransactionMode::Bilateral,
nonce: vec![nonce; 8],
recipient: vec![9u8; 32],
to: b"b32recipient".to_vec(),
message: message.to_string(),
signature: Vec::new(),
authority_policy: None,
};
Expand Down
70 changes: 34 additions & 36 deletions dsm_client/deterministic_state_machine/dsm/src/types/device_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2006,13 +2006,15 @@ mod tests {
Operation::Transfer {
to_device_id: devid(0xAA).to_vec(),
amount: bal(amount),
token_id: b"ERA".to_vec(),
policy_commit,
mode: crate::types::operations::TransactionMode::Bilateral,
nonce: vec![0x11; 32],
recipient: devid(0xAA).to_vec(),
to: Vec::new(),
message: String::new(),
terms_commitment: crate::types::operations::TransferTerms {
token_id: b"ERA".to_vec(),
nonce: vec![0x11; 32],
mode: crate::types::operations::TransactionMode::Bilateral,
memo: String::new(),
salt: vec![0x5A; 32],
}
.commitment(),
signature: Vec::new(),
authority_policy: None,
}
Expand Down Expand Up @@ -2094,13 +2096,15 @@ mod tests {
let xfer = |to: [u8; 32], amt: u64, pcv: [u8; 32]| Operation::Transfer {
to_device_id: to.to_vec(),
amount: bal(amt),
token_id: b"ERA".to_vec(),
policy_commit: pcv,
mode: crate::types::operations::TransactionMode::Unilateral,
nonce: vec![],
recipient: vec![],
to: vec![],
message: String::new(),
terms_commitment: crate::types::operations::TransferTerms {
token_id: b"ERA".to_vec(),
nonce: vec![],
mode: crate::types::operations::TransactionMode::Unilateral,
memo: String::new(),
salt: vec![0x5A; 32],
}
.commitment(),
signature: vec![],
authority_policy: None,
};
Expand Down Expand Up @@ -2183,25 +2187,15 @@ mod tests {
Operation::Transfer {
to_device_id,
amount,
token_id,
policy_commit,
mode,
nonce,
recipient,
to,
message,
terms_commitment,
signature,
..
} => Operation::Transfer {
to_device_id,
amount,
token_id,
policy_commit,
mode,
nonce,
recipient,
to,
message,
terms_commitment,
signature,
authority_policy: Some(AuthorityPolicy {
mode: AuthorityMode::OfflineBearerRequired,
Expand Down Expand Up @@ -2236,13 +2230,15 @@ mod tests {
Operation::Transfer {
to_device_id: to.devid.to_vec(),
amount: bal(amount),
token_id: b"CUSTOM".to_vec(),
policy_commit,
mode: TransactionMode::Bilateral,
nonce: vec![0x5C; 32],
recipient: to.devid.to_vec(),
to: Vec::new(),
message: String::new(),
terms_commitment: crate::types::operations::TransferTerms {
token_id: b"CUSTOM".to_vec(),
nonce: vec![0x5C; 32],
mode: TransactionMode::Bilateral,
memo: String::new(),
salt: vec![0x5A; 32],
}
.commitment(),
signature: Vec::new(),
authority_policy: None,
}
Expand Down Expand Up @@ -2688,13 +2684,15 @@ mod tests {
let bearer_op = |amt: u64| Operation::Transfer {
to_device_id: cp.to_vec(),
amount: bal(amt),
token_id: b"ERA".to_vec(),
policy_commit: token,
mode: TransactionMode::Bilateral,
nonce: vec![],
recipient: vec![],
to: vec![],
message: String::new(),
terms_commitment: crate::types::operations::TransferTerms {
token_id: b"ERA".to_vec(),
nonce: vec![],
mode: TransactionMode::Bilateral,
memo: String::new(),
salt: vec![0x5A; 32],
}
.commitment(),
signature: vec![],
authority_policy: Some(AuthorityPolicy {
mode: AuthorityMode::OfflineBearerRequired,
Expand Down
Loading
Loading