build: keep local build output and checkout state out of the Docker context - #1103
Merged
Merged
Conversation
…ontext The root .dockerignore let a developer checkout's jniLibs, .so files, .claude worktrees, deploy image tar and node bundles into the context of the two root-context builds (ci/docker/StorageNode.Dockerfile and dsm_storage_node/Dockerfile.cloud). On a working Mac that was 7.3GB and filled Docker Desktop's disk during `COPY . .`. Every pattern added is gitignored output; no tracked file matches one, so the guard still sees every source, manifest and its baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y4wDTToHmJfkYYJvMKXt3u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root
.dockerignorelet a developer checkout's local output into the context of the two root-context builds,ci/docker/StorageNode.Dockerfileanddsm_storage_node/Dockerfile.cloud. That output includedjniLibs/,*.so, the.claude/worktrees, the deploy image tar and the node bundles.On the Mac running
dsm_storage_node/deploy/push_and_start.sh, the context came to 7.34GB. Docker Desktop's disk filled up duringCOPY . ., atjniLibs/x86_64/libdsm_sdk.so.Every added pattern is gitignored output, checkout state or a secret bundle. No tracked file matches any of them (checked against
git ls-files), so the real-code guard still sees every source file, every manifest and its baseline.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y4wDTToHmJfkYYJvMKXt3u
Generated by Claude Code