scripts: keep a keystore password's surrounding spaces at the prompt - #1105
Merged
Merged
Conversation
`read` strips leading and trailing whitespace by default, so a keystore password that begins or ends with a space reached keytool and Gradle without it, and the keystore refused a password keytool itself accepts when it prompts. The prompt reads with IFS= so the password is taken as typed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y4wDTToHmJfkYYJvMKXt3u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default,
readstrips leading and trailing whitespace. A keystore password that starts or ends with a space therefore reached keytool and Gradle without that space. The keystore then refused a password thatkeytool -listaccepts when keytool prompts for it itself.The prompt in
scripts/fast_deploy_android_release.shnow reads withIFS=, so the password is used exactly as typed.Tested on a real TTY (via
script) against a PKCS12 keystore whose password isspaced pass: the check opens the keystore and the build proceeds.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y4wDTToHmJfkYYJvMKXt3u
Generated by Claude Code