Skip to content

fix: sync Valentus FOUC paint-hold in head-meta override - #3

Open
AMDphreak wants to merge 1 commit into
mainfrom
fix/fouc-paint-hold
Open

fix: sync Valentus FOUC paint-hold in head-meta override#3
AMDphreak wants to merge 1 commit into
mainfrom
fix/fouc-paint-hold

Conversation

@AMDphreak

Copy link
Copy Markdown
Contributor

Summary

  • Mirror Valentus interim adt-fouc-pending paint-hold so DevCentr brand / mermaid / math CSS does not reintroduce refresh settle.
  • Keep brand links with the other stylesheets before the hold releases.

Test plan

  • Hard-refresh DevCentr docs light/dark: no chrome settle flash.
  • Brand tokens still apply on first paint.

Made with Cursor

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation review — FOUC paint-hold sync

Assessment: The code change correctly restores Valentus interim paint-hold ordering in head-meta.hbs. Documentation was missing upgrade guidance for this pattern.

Docs added/updated (commit 4d24777 on this branch)

File Change
docs/modules/ROOT/pages/publishing/antora-ui-branding.adoc New FOUC paint-hold (interim) section: adt-fouc-pending load order, brand CSS placement, upgrade re-sync steps
docs/modules/ROOT/pages/activity-log.adoc August 2026 entry for this fix
README.adoc supplemental-ui/ row now mentions paint-hold + preference boot
dark-mode-analysis.md Notes paint-hold + brand CSS ordering

Codepaths covered

  • supplemental-ui/partials/head-meta.hbs — global paint-hold, layered CSS, dark-mode/read-width/font-size preference boot, release script
  • valentus-theme upgrade workflow for consumers of the DevCentr supplemental overlay

Knowledge gaps addressed

  • Why the page hides briefly on load (interim until Default UI single-pass CSS)
  • Where brand CSS must sit relative to paint-hold release (before release script, after valentus visual/read-width/font-size CSS)
  • What to re-diff when bumping valentus-theme (upstream paint-hold block + DevCentr brand link)

Gaps not in scope for this PR

  • No separate changelog-details/ structure in this repo — org uses activity-log.adoc instead
  • README still lacks CI/CD badge (pre-existing; not introduced by this PR)
Open in Web View Automation 

Sent by Cursor Automation: Generate docs

Rebase PR #3 onto main: the head-meta paint-hold fix (including
document.fonts.ready release) already landed in 4104c22. This commit
keeps only the documentation — branding guide section, activity-log
entry, README, and dark-mode-analysis — aligned with the current
fonts.ready + 3s fallback implementation.

Co-authored-by: Ryan Johnson <AMDphreak@users.noreply.github.com>
@cursor
cursor Bot force-pushed the fix/fouc-paint-hold branch from 4d24777 to 6e10721 Compare August 25, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants