Keep researched names inside the country the question named - #55
Merged
Conversation
A German Amtsträger line is no longer Answer: Friedrich Merz for a Russian president, and a correction like nein in Russland researches again instead of guessing from training data. Co-authored-by: Sebastian <devbadya@users.noreply.github.com>
devbadya
marked this pull request as ready for review
September 10, 2026 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two live failures on
wer ist der russische präsident/nein in russland:researchsearchedrussische präsidentand still opened with a German Amtsträger line (Friedrich Merz, Bundespräsident / Bundeskanzler).extractAnswertreated anyAmtsträger ist … Namesentence — and any… ist … präsidentsentence — as the answer, without requiring Russia in that source.wrong-factthen forced the model to repeat Merz.nein in russlandkept the research skill (short fragment) and did not call the tool. The 0.8B model answered from training data: “I believe … Vladimir Putin … since October 2009”. It cannot know this without researching again.Fix
Amtsträger ist Friedrich Merzstill answers Bundeskanzler; it does not answer russische Präsident.related()treats russische / Russland / Russia as the same place so Wikipedia ranking prefers Präsident Russlands.researchagain withPräsident Russland.conversationTopicpins the last office onto that correction, the same way und der von Frankreich? keeps Bundeskanzler.Tests
extractAnswerrejects Merz for a Russia question, accepts Putin from Präsident Russlands, and prefers Putin when both pages are present.pickCandidatesgives the Wikipedia slot to Präsident Russlands, not Bundespräsident.nein in russland.web-follow-up-correction.pnpm checkis green (1,346 tests). This does not claim the 0.8B model behaves correctly on a GPU; that still needs/?evalin Chrome or Edge.Out of scope
No longer system prompt, no auto-learning from every question, no second model call per turn.