add project parameter for build api - #486
Closed
donhui wants to merge 2 commits into
Closed
Conversation
for more information, see https://pre-commit.ci
| url = "" | ||
| if self.project: | ||
| url = f"?project='{self.project}'" | ||
| url = f"?project={self.project}" |
Member
There was a problem hiding this comment.
not sure that is a necessary change. Might harm project names with spaces
Member
There was a problem hiding this comment.
I guess it's not possible https://docs.jfrog.com/projects/docs/create-a-project 🤔
harm project names with spaces
Project Key, enter a unique key used to identify your Project resources.
The Project Key is added as a prefix to resources created within the Project. This field is mandatory, supports 2 to 32 lowercase alphanumeric characters and hyphens, and must start with a letter.
| build_number = urllib.parse.quote(str(build_number), safe="") | ||
| url += f"/{build_number}" | ||
| if self.project: | ||
| url += f"?project={self.project}" |
beliaev-maksim
requested changes
Jul 14, 2026
beliaev-maksim
left a comment
beliaev-maksim
left a comment
Member
There was a problem hiding this comment.
also tests are missing
| } | ||
|
|
||
| if self.project: | ||
| json_data["prjoect"] = self.project |
Member
There was a problem hiding this comment.
Suggested change
| json_data["prjoect"] = self.project | |
| json_data["project"] = self.project |
Member
|
Combined one #503 |
allburov
added a commit
that referenced
this pull request
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #452