This repository was archived by the owner on Jul 6, 2026. It is now read-only.
chore: bump ic-rusqlite to 0.5 and fold rusqlite_db into the workspace - #35
Merged
Merged
Conversation
ic-rusqlite 0.5 uses ic-cdk 0.20, matching the workspace, so rusqlite_db no longer needs to live outside it. Switch its Cargo.toml to workspace deps and drop its standalone Cargo.lock. ic-rusqlite's build script still panics on non-wasm32 targets, so: - CI host clippy/test now use --workspace --exclude rusqlite_db - A new CI step runs clippy on rusqlite_db with --target wasm32-wasip1
|
✅ No security or compliance issues detected. Reviewed everything up to d7628e4. Security Overview
Detected Code Changes| Change Type | Relevant files |
tmu0
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ic-rusqlite 0.5 uses ic-cdk 0.20, matching the workspace, so rusqlite_db no longer needs to live outside it. Switch its Cargo.toml to workspace deps and drop its standalone Cargo.lock.
ic-rusqlite's build script still panics on non-wasm32 targets, so: