build: update pinned ci-tools to a98f5d0 - #306
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates pinned dfinity/ci-tools references to a98f5d0, including the changelog app-token fix.
Changes:
- Refreshes CI, release, testing, and validation workflow pins.
- Updates changelog and release automation workflows.
| File | Description |
|---|---|
.github/workflows/release.yml |
Updates release and documentation pins |
.github/workflows/lint.yml |
Updates PNPM setup pin |
.github/workflows/generate-changelog.yml |
Updates changelog workflow |
.github/workflows/e2e-test-nodejs.yml |
Updates E2E setup pins |
.github/workflows/create-release-pr.yml |
Updates release PR tooling pins |
.github/workflows/commitizen.yml |
Updates validation workflow pins |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lwshang
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up dfinity/ci-tools#94.
bdfe993..a98f5d0is only that commit.Since
reuse_branch(dfinity/ci-tools#80), the changelog pull request is force pushed on every push tomain, and those pushes came from the default token asgithub-actions[bot]. Its workflows then waited for approval, and requiredpull_request_targetworkflows such as the External PR Ruleset never ran, which blocks the pull request even when approved (e.g. #290). With #94, the branch is pushed with the app token instead.🤖 Generated with Claude Code