docs: la til 5 illustrasjoner og la til *-20 farger - #58
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The illustration build has a critical palette-marker failure and unresolved compatibility and rendering issues.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Refreshes Digdir illustrations with renamed assets, updated metadata, new illustrations, and expanded palette support.
Changes:
- Adds and updates illustration SVGs and metadata.
- Renames or removes superseded assets.
- Extends the color palette and recoloring markers.
| File | Change / review note |
|---|---|
packages/varde/illustrations/digdir/tre-personer-som-snakker-sammen/meta.json |
Adds metadata. |
packages/varde/illustrations/digdir/to-personer-som-stabler-former/meta.json |
Clarifies title. |
packages/varde/illustrations/digdir/to-personer-som-holder-former/meta.json |
Adds metadata; moderate issue (2 votes) regarding removal of the documented export. |
packages/varde/illustrations/digdir/to-personer-som-holder-en-sirkel-sammen/to-personer-som-holder-en-sirkel-sammen.svg |
Adds illustration asset. |
packages/varde/illustrations/digdir/to-personer-som-holder-en-sirkel-sammen/meta.json |
Clarifies title. |
packages/varde/illustrations/digdir/personer-som-stabler-former/personer-som-stabler-former.svg |
Removes superseded asset. |
packages/varde/illustrations/digdir/personer-som-holder-flere-former/meta.json |
Removes legacy metadata. |
packages/varde/illustrations/digdir/personer-som-holder-figurer/meta.json |
Removes legacy metadata. |
packages/varde/illustrations/digdir/personer-som-holder-en-sirkel-sammen/personer-som-holder-en-sirkel-sammen.svg |
Removes superseded asset. |
packages/varde/illustrations/digdir/person-som-strekker-seg/person-som-strekker-seg.svg |
Replaces SVG filename/content. |
packages/varde/illustrations/digdir/person-som-strekker-seg/person som strekker.svg |
Adds renamed asset. |
packages/varde/illustrations/digdir/person-som-ser-pa-telefonen/person-som-ser-pa-telefonen.svg |
Removes superseded asset. |
packages/varde/illustrations/digdir/person-som-ser-pa-telefonen-sin/person-som-ser-pa-telefonen-sin.svg |
Adds renamed asset. |
packages/varde/illustrations/digdir/person-som-ser-pa-telefonen-sin/meta.json |
Adds metadata. |
packages/varde/illustrations/digdir/person-som-ser-pa-telefonen-sin-og-snakker/person-som-ser-på-telefonen-sin-og-snakker.svg |
Adds renamed asset. |
packages/varde/illustrations/digdir/person-som-ser-pa-telefonen-sin-og-snakker/meta.json |
Adds metadata. |
packages/varde/illustrations/digdir/person-som-ser-pa-telefonen-og-snakker/person-som-ser-pa-telefonen-og-snakker.svg |
Removes superseded asset. |
packages/varde/illustrations/digdir/person-som-gestikulerer/person-som-gestikulerer.svg |
Removes asset; moderate issue (1 vote) regarding removal of the public export. |
packages/varde/illustrations/digdir/person-som-gestikulerer/meta.json |
Removes metadata; moderate issue (1 vote) regarding removal of the public export. |
packages/varde/illustrations/digdir/person-som-gar/person-som-gar.svg |
Adds illustration asset. |
packages/varde/illustrations/digdir/person-som-gar/meta.json |
Adds metadata. |
packages/varde/illustrations/digdir/person-som-gar-med-sirkel/person-som-gar-med-sirkel.svg |
Adds asset; critical issue (4 votes) due to the invalid bran1 palette marker. |
packages/varde/illustrations/digdir/person-som-gar-med-sirkel/meta.json |
Adds metadata. |
packages/varde/illustrations/digdir/person-som-gar-med-kaffe-og-koffert/person-som-gar-med-kaffe-og-koffert.svg |
Adds illustration and color slots. |
packages/varde/illustrations/digdir/person-som-gar-med-kaffe-og-koffert/meta.json |
Adds metadata. |
packages/varde/illustrations/digdir/person-som-forklarer/meta.json |
Adds metadata; moderate issue (1 vote) regarding removal of the old public export. |
packages/varde/illustrations/digdir/person-som-forklarer/Illusperson-som-forklarer.svg |
Adds replacement illustration. |
packages/varde/illustrations/digdir/person-omringet-av-stjerner/person-omringet-av-stjerner.svg |
Removes superseded asset. |
packages/varde/illustrations/digdir/person-omringet-av-stjerner/person-omgitt-av-stjerner.svg |
Adds renamed asset; moderate issue (1 vote) regarding altered star geometry. |
packages/varde/illustrations/digdir/person-omringet-av-stjerner/meta.json |
Updates title. |
packages/varde/illustrations/digdir/person-med-jojo/meta.json |
Simplifies description. |
packages/varde/illustrations/digdir/person-med-hendene-pa-hoftene/person-med-hendene-pa-hoftene.svg |
Normalizes SVG structure. |
packages/varde/illustrations/digdir/person-med-hendene-pa-hoftene/meta.json |
Simplifies description. |
packages/varde/illustrations/digdir/colors.json |
Adds subbrand colors and updates red; moderate issue (4 votes) for duplicate color resolution, plus a nit (1 vote) for the outdated README example. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Barsnes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.