Fix FastAPI initialization argument unpacking - #10
Open
digo5ds wants to merge 1 commit into
Open
Conversation
Owner
Author
|
/gemini-review |
4 similar comments
Owner
Author
|
/gemini-review |
Owner
Author
|
/gemini-review |
Owner
Author
|
/gemini-review |
Owner
Author
|
/gemini-review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| from app.routes.aws_services_routes import router | ||
|
|
||
| app = FastAPI(**FASTAPI_CONFIG) | ||
| app = FastAPI(*FASTAPI_CONFIG |
There was a problem hiding this comment.
The change from **FASTAPI_CONFIG (dictionary unpacking) to *FASTAPI_CONFIG (iterable unpacking) is likely a bug. FastAPI expects keyword arguments for its configuration (e.g., title, description, version). Passing an iterable will cause a TypeError unless FASTAPI_CONFIG was explicitly refactored to be a list/tuple of keyword arguments, which is non-standard for configuration objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.