Feat/add pfs entities changes - #5
Open
YogeshManni wants to merge 6 commits into
Open
YogeshManni wants to merge 6 commits into
YogeshManni wants to merge 6 commits into
Conversation
- Clone of proven CEM subset extract with corp type filter swapped to PFS (32 spots)
- Add PFS to tombstone, auth, and batch-delete corp type filters - Add PFS to subset extract generator supported types
- verify_filings fetched effective_dt on both sides but never compared them - add date-part comparison (COLIN naive midnight vs LEAR timestamptz) with NULL handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity###
Description of changes:
Tickets -
PFS migration - https://app.zenhub.com/workspaces/entity-mainframe-migration-6a3d9c99d01e12000f3443e9/issues/gh/bcgov/entity/34863
Verification - https://app.zenhub.com/workspaces/entity-mainframe-migration-6a3d9c99d01e12000f3443e9/issues/gh/bcgov/entity/34978
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).