Skip to content

Fix test flake in f64::symmetric_eigen by slightly increasing epsilon - #1621

Merged
Ralith merged 1 commit into
dimforge:mainfrom
jorgeandrecastro:fix-symmetric-eigen-flake-1361
Sep 30, 2026
Merged

Ralith merged 1 commit into
dimforge:mainfrom
jorgeandrecastro:fix-symmetric-eigen-flake-1361

Conversation

@jorgeandrecastro

Copy link
Copy Markdown
Contributor

Hello!

I saw issue #1361 regarding the test flakes on symmetric_eigen and wanted to try contributing a fix.

What was done: I slightly increased the tolerance epsilon (from 1.0e-5 to 1.0e-4) in the proptests for symmetric_eigen and symmetric_eigen_singular to prevent false positives caused by floating-point rounding variations on certain random matrices of size 14.

Testing: I ran the tests locally (cargo test symmetric_eigen), and everything passed successfully.

I am thrilled to try contributing to this awesome project! Please let me know if this approach is okay, if there are better practices to follow, or if you disagree with anything. I am entirely open to feedback.

Thank you very much for your guidance!

Comment thread tests/linalg/eigen.rs Outdated
@jorgeandrecastro
jorgeandrecastro force-pushed the fix-symmetric-eigen-flake-1361 branch from bff57aa to 6da03a6 Compare September 30, 2026 13:38
@Ralith
Ralith merged commit b2466e6 into dimforge:main Sep 30, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants