Repository navigation
Fix matrix view overflow 1418 - #1622
Open
jorgeandrecastro wants to merge 2 commits into
Open
jorgeandrecastro wants to merge 2 commits into
jorgeandrecastro wants to merge 2 commits into
Conversation
jorgeandrecastro
force-pushed
the
fix-matrix-view-overflow-1418
branch
from
September 30, 2026 20:30
7c711c3 to
be8e575
Compare
Ralith
approved these changes
Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Changes Made:
Updated offset and dimension calculations in assert_view_index (src/base/matrix_view.rs) to use .checked_add() and .checked_mul().
This prevents silent integer wrap-arounds in release mode that could lead to memory corruption (munmap_chunk).
Im open to any feedback or alternative approaches. Thank you!