FIX: Include PostgreSQL 15 in test images - #1096
Merged
Merged
Conversation
The test images installed server and extension packages only for `PG_MAJOR`. After the default moved to PostgreSQL 18, Discourse structure-dump tasks could no longer start a compatible PostgreSQL 15–16 server. This commit exports `PG_MAJOR_OLD`, installs its server, contrib, and pgvector packages in every test image, and verifies its `pg_ctl` exists during the image build.
Installing `postgresql-${PG_MAJOR_OLD}` already fails the image build if the package or its binaries are unavailable, so the explicit `pg_ctl` path assertion adds no additional guarantee.
nattsw
approved these changes
Jul 30, 2026
tgxworld
marked this pull request as ready for review
July 30, 2026 06:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test images installed server and extension packages only for
PG_MAJOR. After the default moved to PostgreSQL 18, Discourse structure-dump tasks could no longer start a compatible PostgreSQL 15–16 server.This commit exports
PG_MAJOR_OLDand installs its server, contrib, and pgvector packages in every test image so structure-dump tasks can continue using PostgreSQL 15 alongside PostgreSQL 18.