Update to using the version of SolarSTEPS with arctan2 - #19
Merged
Conversation
KristianHMoller
added a commit
to KristianHMoller/sunflow
that referenced
this pull request
Jul 19, 2026
KristianHMoller
added a commit
that referenced
this pull request
Aug 7, 2026
* First ensemble functionality * Remove forcing of only a single ensemble member * Configurable noise parameters * Linting * Add support for ensemble median and have that be default * Update changelog * Make ensemble_members a CLI argument * Adding ensemble statistics to default output with more than one ensemble member * Linting * Crop also in ensemble mode * Change PA ensemble noise to match paper * Linting * Update to using the version of SolarSTEPS with arctan2 (#19) * Do cropping to output domain right after forecast calculation for efficiency * Verify also t0 clear-sky * Validate number of ensemble members prior to saving ensemble * Move enforcing of 4d ratio to main for future-proofing * Revert order of {statistic} and rest of variable name in output * Revert "Remove forcing of only a single ensemble member" This reverts commit 5406030. * Verify that number of ensemble members is greater than 0 * Minor review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enesmble branch of SolarSTEPS has been updated to using
arctan2instead ofarctan, yielding correct behavior for all directions of flow: dmidk/SolarSTEPS#2This PR updates pyproject.toml to use the version of SolarSTEPS with this update.