DirStructureAsync: carry the struct's where clause over into the generated future enums - #3
Merged
Conversation
KiSetsuFu-PuLiN
force-pushed
the
fix/missing-where-clauses
branch
from
September 21, 2026 07:47
cf1f4f9 to
e3f9f0a
Compare
dnbln
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[derive(DirStructureAsync)]inherits the derived struct'swhereclause in the generated trait impls, but not in the generatedtype Futureenums — those are emitted with the per-field bounds only. When a struct's ownwhereclause carries bounds that the generated code needs (e.g. bounds required by a customFilterfor a generic path type), compilation fails inside the derive expansion even though the bounds are written on the struct itself.derive_where_clausemodule): without the fix it fails with<Vfs as VfsCore>::Path: MyTrait is not satisfied.future_impl_enumindir_structure_async/{read_from_async.rs, write_to_async_ref.rs}), consistently with what the impl generation already does.