feat: implement WriteToAsyncRef for () - #4
Merged
Merged
Conversation
KiSetsuFu-PuLiN
force-pushed
the
unit-write-to-async-ref
branch
from
September 21, 2026 17:19
208da87 to
e53d772
Compare
dnbln
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
WriteToAsyncReffor(), as a no-op mirroring the existingReadFromAsyncandWriteToAsyncimplementations.This also makes
DirChildren<(), _>satisfyWriteToAsyncRef, so the unit type can be used as a placeholder entry type that writes out an empty directory skeleton.Adds a test covering both aspects: writing
()directly is a no-op (creates no files), and aDirChildren<(), _>value can be written through the new impl.