Skip to content

fix(ci): pin QEMU setup in release.yml to stop arm64 npm ci crash - #215

Merged
docdyhr merged 1 commit into
mainfrom
fix/release-docker-qemu-crash
Jul 30, 2026
Merged

fix(ci): pin QEMU setup in release.yml to stop arm64 npm ci crash#215
docdyhr merged 1 commit into
mainfrom
fix/release-docker-qemu-crash

Conversation

@docdyhr

@docdyhr docdyhr commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • release.yml's docker-publish job builds linux/amd64,linux/arm64 but never explicitly set up QEMU — it relied on whatever binfmt emulator the ubuntu-latest runner image ships by default.
  • That default QEMU crashes mid-npm ci on the emulated arm64 leg with qemu: uncaught target signal 4 (Illegal instruction) - core dumped, then hangs instead of failing fast.
  • This exact signature caused the v3.3.19 incident (job ran until the default 6h timeout). PR fix(ci): bound docker-publish job timeout, fix dead retry-on-hang path #207/fix(ci): make Docker retry step continue-on-error so real verification decides success #208 added job/step timeouts, a retry, and a real docker pull verification step to contain the damage and report failure honestly — but none of that fixes the underlying crash.
  • It recurred on the v3.3.25 release (2026-07-29): both the primary build attempt and the retry hit the identical crash at the identical point (~29s into npm ci), each ran its full 30-minute timeout, and the image was never published — docker.io/docdyhr/mcp-wordpress:3.3.25 doesn't exist, latest is still stamped from 3.3.24.
  • docker-modern.yml already pins docker/setup-qemu-action@v4 before its buildx setup and has had zero arm64 crashes across its last 5 runs. This PR adds the same step to release.yml's docker-publish job.

Test plan

  • YAML validated (js-yaml)
  • npx prettier --check passes on the changed file
  • Pre-commit hooks (lint, typecheck, 384 security tests) passed
  • Pre-push hooks (build, 2416-test suite across 4 batches, 384 security tests, production dependency audit gate) all passed
  • Next release's Docker publish job should be watched to confirm the arm64 leg no longer crashes

🤖 Generated with Claude Code

Summary by Sourcery

CI:

  • Add an explicit docker/setup-qemu-action@v4 step to the release.yml docker-publish job to provide a reliable multi-architecture emulator for linux/arm64 builds.

…i crash

The docker-publish job's linux/arm64 leg relied on whatever QEMU binfmt the
runner image ships by default, which crashes mid-npm ci with 'qemu: uncaught
target signal 4 (Illegal instruction) - core dumped'. This happened on v3.3.19
(job ran until the 6h default timeout) and again on v3.3.25 (both the primary
attempt and its retry hung for their full 30m timeouts, identically crashing at
the same step ~29s into npm ci, so the image never published for that release).

docker-modern.yml already pins docker/setup-qemu-action@v4 before buildx setup
and has had zero arm64 crashes across its last 5 runs, so add the same step to
release.yml's docker-publish job.
Copilot AI review requested due to automatic review settings July 30, 2026 18:26
@sourcery-ai

sourcery-ai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins QEMU setup in the release Docker publish workflow to use a known-good multi-platform emulator for arm64, mirroring the configuration used in docker-modern.yml to prevent npm ci crashes during arm64 builds.

Flow diagram for updated QEMU setup in release Docker publish workflow

flowchart LR
    subgraph docker_publish_job
        checkout["📥 Checkout Code"] --> setup_qemu["🐳 Set up QEMU (Multi-platform)"] --> setup_buildx["🐳 Set up Docker Buildx"]
    end
Loading

File-Level Changes

Change Details Files
Configure a pinned QEMU setup step in the release workflow's docker-publish job to stabilize linux/arm64 emulation.
  • Add a dedicated 'Set up QEMU (Multi-platform)' step before Docker Buildx setup in the docker-publish job
  • Use docker/setup-qemu-action@v4 to ensure a consistent QEMU/binfmt configuration across runs
  • Document in inline comments the past arm64 npm ci crashes and rationale for pinning QEMU, referencing previous incidents and existing stable workflow configuration
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The QEMU setup step’s inline comment is quite long and incident-specific; consider trimming it to the essential rationale (e.g., ‘pin QEMU to avoid arm64 npm ci crashes seen on previous releases’) to keep the workflow file easier to scan and maintain.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The QEMU setup step’s inline comment is quite long and incident-specific; consider trimming it to the essential rationale (e.g., ‘pin QEMU to avoid arm64 npm ci crashes seen on previous releases’) to keep the workflow file easier to scan and maintain.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR stabilizes the Docker multi-architecture (linux/amd64, linux/arm64) publish step in the release workflow by explicitly installing a known QEMU/binfmt setup instead of relying on the runner’s default emulator.

Changes:

  • Add an explicit docker/setup-qemu-action@v4 step to the docker-publish job in release.yml.
  • Align release.yml’s multi-arch setup ordering with the already-working docker-modern.yml pattern (QEMU → Buildx).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@docdyhr
docdyhr merged commit d8cd4b1 into main Jul 30, 2026
30 checks passed
@docdyhr
docdyhr deleted the fix/release-docker-qemu-crash branch July 30, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants