build/bake: BuildKit secrets support#248
Open
crazy-max wants to merge 1 commit into
Open
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
8a0cb82 to
f81277e
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #40
closes #239
This adds BuildKit secret support to the build and bake reusable workflows through a shared
build-secretsworkflow secret.The new
build-secretssecret accepts a YAML object that maps BuildKit secret IDs to secret values. The build workflow parses that YAML and forwards each entry todocker/build-push-actionthroughsecret-envs. The bake workflow uses the same contract and appends matching*.secrets+=id=...,env=...overrides fordocker/bake-action.A caller can pass a literal multiline secret with YAML block syntax.
A caller can also pass GitHub secrets through
toJSON(...)so multiline values and YAML-sensitive characters are preserved.Reusable workflows cannot accept arbitrary dynamic secret names, so this keeps the public contract stable while still allowing callers to provide any BuildKit secret ID they need. File-based secrets are intentionally not supported because these workflows build from Git context and do not checkout the caller repository, so caller workspace paths are not available in the build job.