Fix GHCR login in image workflow - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the failing GHCR login in the
Build Docs Toolbox Imageworkflow.The workflow previously piped
secrets.GHCR_PATintodocker login, and the currentmainrun failed with:The workflow already grants
packages: write, so this switches the login step todocker/login-action@v3using the repository-scopedGITHUB_TOKEN.Validation
28875416428; failure occurs inLogin to GHCR.contents: readandpackages: writepermissions.workflow_dispatchon the branch because that would push branch-built image artifacts to GHCR as an external side effect. The intended verification path is themainpush after merge.