Start the ft_marth units - #130
Open
vagnertxr wants to merge 2 commits into
Open
Conversation
Fills in the stubs and one-liners across the five ft_marth translation units, which were declared and split but had empty sources. 27 functions match; the units stay NonMatching. Most are empty bodies or constant returns. The rest: - fn_106_DB60 reads a byte at +132. - fn_106_BE30 is __fabs, taking and returning double. A float signature costs a frsp the target does not have. - fn_106_BFE0, fn_106_C98C and fn_106_D400 install a table pointer. - fn_106_CD00 stores two float arguments. Three are left as NONMATCHING with a note: fn_106_D4E4 and fn_106_C390 copy floats between objects, and mwcc hoists the loads ahead of the stores while the target interleaves them. Struct assignment, field by field and raw float pointers all produce the same schedule. Verified: `ninja` reports 127 files OK. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
fn_106_D9E0 and fn_106_DA2C are a matched pair guarding a byte at +136: one calls into g_IfMngr and raises the flag, the other calls the opposite entry point and clears it. Both reach 98%. What is left is argument evaluation order. The target dereferences g_IfMngr before loading the field at +72; mwcc does it the other way round, and hoisting the manager into a local or going through IfMngr::getInstance() does not move it. Verified: `ninja` reports 127 files OK. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills in the stubs and one-liners across the five
ft_marthtranslation units, which were already declared inconfigure.pyand split insplits.txtbut had empty sources. 27 functions match; the units stayNonMatching.ft_marth_status_uniq_process_special_sif_marth_finalft_marth_status_uniq_process_special_hift_marth_status_uniq_process_special_finalft_marth_status_uniq_process_special_lw