docs: update macOS build instructions - #158
Open
MagiHotline wants to merge 2 commits into
Open
Conversation
Collaborator
|
Lets just update the readme to latest dtk-template version rather than have our own wording/instructions |
Author
|
Does the NInja Build pull the right wibo if MacOs system is detected? |
Collaborator
IDK, maybe we need to update other parts of dtk-template too so it fetches the right thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A very small PR that changes the README instructions for arm64 macOS.
Reasons
The macOS build instruction were outdated since the developers of Wine Crossover officially removed their binary from the brew packages since it's no longer maintained. In this PR I take for granted that every macOS user has Rosetta 2 (s a macOS component that automatically translates Intel-based) already installed.
Testing Done
Verified from a clean clone on macOS:
python3 configure.py [args]ninja(up to checksum validation)Problems encountered
During building,
wibofailed because it is trying to executesjiswrap.exe, which uses Win32 API functions that wibo does not implement. Sincesjiswrap.exeis only needed on systems where the compiler cannot handle Shift-JIS source files properly under Wine, I decided to bypass it via:After this, it got fixed. But I'm not really sure to add this in the README too.