Skip to content

MarioUtil/MathUtil: match MsMtxSetXYZRPH - #160

Merged
Mrkol merged 1 commit into
doldecomp:mainfrom
gitRasheed:rasheed/match-msmtxsetxyzrph
Sep 9, 2026
Merged

MarioUtil/MathUtil: match MsMtxSetXYZRPH#160
Mrkol merged 1 commit into
doldecomp:mainfrom
gitRasheed:rasheed/match-msmtxsetxyzrph

Conversation

@gitRasheed

Copy link
Copy Markdown
Contributor

Testing the waters with SMS and wanted to start with something small and simple. Adjusted the matrix store order and multiplication grouping, reusing four sine/cosine products.

@decomp-dev

decomp-dev Bot commented Sep 9, 2026

Copy link
Copy Markdown

Report for GMSJ01 (fc449db - 1b370af)

📈 Matched code: 38.82% (+0.00%, +176 bytes)
📉 Linked code: 17.39% (-0.06%, -2316 bytes)
📉 Linked data: 20.68% (-0.00%, -28 bytes)

✅ 1 new match
Unit Item Bytes Before After
mario/MarioUtil/MathUtil MsMtxSetXYZRPH(float(*)[4], float, float, float, short, short, short) +77 56.75% 100.00%
📉 1 regression in an unmatched item
Unit Item Bytes Before After
mario/JSystem/JAudio/JASystem/JASDSPChannel JASystem::TDSPChannel::updateAll() -1 99.88% 99.77%

@Mrkol
Mrkol merged commit 9d80b2f into doldecomp:main Sep 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants