GUI layout instruments, and the ceiling figures re-measured - #17
Merged
Conversation
Twelve files that let a screen be measured and looked at without running the application: a layout probe with rules stating what is wrong under any taste, a contrast report measured against the painted background rather than a declared one, a spacing report split into ours and the toolkit's, a sweep across five window sizes, and the contact sheet that renders every session state from protocol events alone. They enter the test-cs gate, which goes from 431 to 449 assertions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The ceilings themselves are unchanged and still equal today's maxima, so no gate moves. What had gone stale is the prose beside them, which this project treats as a measurement rather than a note. Measured by asking each lint for every item at once - clippy through CLIPPY_CONF_DIR with the thresholds lowered, the analyzers through -p:ChronoMetricsConfig with a copy of the config, both mechanisms the repository already uses for its pinning gates, so nothing here was swapped in place. Cross-checked by prediction rather than by trusting one run. What moved: the two functions behind cdp_session swapped places, the cognitive-complexity tie is gone and four items have appeared between the holder and the previously named runner-up, a fourth block now reaches the nesting ceiling, and both CA1506 runners-up are higher than recorded. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, one about tests and one about prose beside numbers. No product code changes, no gate thresholds moved.
What is here
Layout instruments (12 files). A screen can now be laid out, measured and looked at without running the application: where every element landed, which layout facts are wrong under any taste, contrast measured against the background that was actually painted, spacing split into ours and the toolkit's, a sweep across five window sizes, and a contact sheet rendered from protocol events alone. They enter the
test-csgate, taking it from 431 to 449 assertions.Ceiling figures. The ceilings in
clippy.tomlandgui/CodeMetricsConfig.txtare a ratchet: the number IS today's maximum, and both are unchanged here. What had gone stale is the prose beside them. The two functions behindcdp_sessionhad swapped places, the cognitive-complexity tie was gone with four items now between the holder and the previously named runner-up, a fourth block had reached the nesting ceiling, and both CA1506 runners-up were higher than recorded.Measured by asking each lint for every item at once - clippy through
CLIPPY_CONF_DIR, the analyzers through-p:ChronoMetricsConfig- both mechanisms this repository already uses for its pinning gates, so nothing was swapped in place. Cross-checked by prediction: at a threshold of 165 exactly two functions fire, which is only true if one is at or below 165 and the other above it.Verification
Full local gate run including the harness: 14/14 OK in 214 s.
🤖 Generated with Claude Code