[Perf] async void => Task - #4524
Open
benrr101 wants to merge 1 commit into
Open
Conversation
benrr101
added
the
Performance 📈
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DataTypeReaderAsyncRunner BenchmarkDotNet benchmarks to return Task instead of using async void, ensuring BenchmarkDotNet can properly await asynchronous benchmark execution and produce reliable measurements.
Changes:
- Converted all async benchmark entrypoints from
public static async void ... => await ...topublic static Task ... => .... - Removed unnecessary
async/awaitwrappers in benchmark methods while preserving the underlying async benchmark implementation (RunBenchmarkAsync).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cheenamalhotra
approved these changes
Aug 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4524 +/- ##
==========================================
- Coverage 64.73% 62.74% -1.99%
==========================================
Files 288 283 -5
Lines 44088 67041 +22953
==========================================
+ Hits 28542 42068 +13526
- Misses 15546 24973 +9427
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
🤖 This PR updates the DataTypeReaderAsyncRunner to use
Taskinstead ofasync voidfor its benchmarks. According to 🤖 usingasync voidcauses BenchmarkDotNet to not properly await the tasks, which might cause issues with we are measuring performance. Since we want to ensure that our measurements are reliable, this will be the base branch for all upcoming perf improvements.Issues
N/A