Skip to content

[6.1.7 Cherry-pick] Address CodeQL finding: PKCS#1 padding (SM03799) #4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 2 commits into
base: release/6.1
Choose a base branch
from
+6 −0
Open

[6.1.7 Cherry-pick] Address CodeQL finding: PKCS#1 padding (SM03799) #4526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5ea94a
Cherry-pick of #4517 requires manual resolution
github-actions[bot] Aug 10, 2026
6c3a6fc
Address CodeQL SM03799 (PKCS#1 padding) in Always Encrypted key store…
cheenamalhotra Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...lient/src/Microsoft/Data/SqlClient/SqlColumnEncryptionCertificateStoreProvider.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,7 @@ private byte[] RSASignHashedData(byte[] dataToSign, X509Certificate2 certificate
RSA rsa = certificate.GetRSAPrivateKey();

// Prepare RSAPKCS1SignatureFormatter for signing the passed in hash
// CodeQL [SM03799] Required for an external standard: Always Encrypted signs encrypted column encryption keys with RSA PKCS#1 v1.5 (https://learn.microsoft.com/en-us/sql/t-sql/statements/create-column-encryption-key-transact-sql?view=sql-server-ver16)
RSAPKCS1SignatureFormatter rsaFormatter = new RSAPKCS1SignatureFormatter(rsa);
//Set the hash algorithm to SHA256.
rsaFormatter.SetHashAlgorithm(HashingAlgorithm);
Expand All @@ -537,6 +538,7 @@ private bool RSAVerifySignature(byte[] dataToVerify, byte[] signature, X509Certi
RSA rsa = certificate.GetRSAPrivateKey();

// Prepare RSAPKCS1SignatureFormatter for signing the passed in hash
Comment thread
cheenamalhotra marked this conversation as resolved.
// CodeQL [SM03799] Required for an external standard: Always Encrypted signs encrypted column encryption keys with RSA PKCS#1 v1.5 (https://learn.microsoft.com/en-us/sql/t-sql/statements/create-column-encryption-key-transact-sql?view=sql-server-ver16)
RSAPKCS1SignatureDeformatter rsaDeFormatter = new RSAPKCS1SignatureDeformatter(rsa);

//Set the hash algorithm to SHA256.
Expand Down
2 changes: 2 additions & 0 deletions ...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlColumnEncryptionCngProvider.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ private byte[] RSASignHashedData(byte[] dataToSign, RSACng rsaCngProvider)
Debug.Assert((dataToSign != null) && (dataToSign.Length != 0));
Debug.Assert(rsaCngProvider != null);

// CodeQL [SM03799] Required for an external standard: Always Encrypted signs encrypted column encryption keys with RSA PKCS#1 v1.5 (https://learn.microsoft.com/en-us/sql/t-sql/statements/create-column-encryption-key-transact-sql?view=sql-server-ver16)
return rsaCngProvider.SignData(dataToSign, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1);
}

Expand All @@ -317,6 +318,7 @@ private bool RSAVerifySignature(byte[] dataToVerify, byte[] signature, RSACng rs
Debug.Assert((signature != null) && (signature.Length != 0));
Debug.Assert(rsaCngProvider != null);

// CodeQL [SM03799] Required for an external standard: Always Encrypted signs encrypted column encryption keys with RSA PKCS#1 v1.5 (https://learn.microsoft.com/en-us/sql/t-sql/statements/create-column-encryption-key-transact-sql?view=sql-server-ver16)
return rsaCngProvider.VerifyData(dataToVerify, signature, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1);
}

Expand Down
2 changes: 2 additions & 0 deletions ...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlColumnEncryptionCspProvider.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ private byte[] RSASignHashedData(byte[] dataToSign, RSACryptoServiceProvider rsc
Debug.Assert((dataToSign != null) && (dataToSign.Length != 0));
Debug.Assert(rscp != null);

// CodeQL [SM03799] Required for an external standard: Always Encrypted signs encrypted column encryption keys with RSA PKCS#1 v1.5 (https://learn.microsoft.com/en-us/sql/t-sql/statements/create-column-encryption-key-transact-sql?view=sql-server-ver16)
return rscp.SignData(dataToSign, HashingAlgorithm);
}

Expand All @@ -326,6 +327,7 @@ private bool RSAVerifySignature(byte[] dataToVerify, byte[] signature, RSACrypto
Debug.Assert((signature != null) && (signature.Length != 0));
Debug.Assert(rscp != null);

// CodeQL [SM03799] Required for an external standard: Always Encrypted signs encrypted column encryption keys with RSA PKCS#1 v1.5 (https://learn.microsoft.com/en-us/sql/t-sql/statements/create-column-encryption-key-transact-sql?view=sql-server-ver16)
return rscp.VerifyData(dataToVerify, HashingAlgorithm, signature);
}

Expand Down
Loading