Bump current XBD packages for fixed AAR packaging - #1539
Conversation
There was a problem hiding this comment.
Pull request overview
This PR revises the NuGet revision (nugetVersion 4th component) for all currently published Xamarin.Build.Download (XBD) AAR-based packages so they can be regenerated and re-published using the fixed XBD packing templates (from #1520), avoiding duplicate inclusion of proprietary AARs (and eliminating duplicate XA4301 native-library warnings such as in Xamarin.Firebase.Crashlytics.NDK).
Changes:
- Bumped
nugetVersionby one revision across the affected published XBD AAR packages (e.g.,120.1.0→120.1.0.1for Crashlytics / Crashlytics.NDK). - Left Maven
versionvalues unchanged; this is strictly a NuGet re-release to pick up packaging/template fixes. - Included all relevant Crashlytics/Crashlytics.NDK entries implicated by #1538 so regenerated packages no longer embed + download the same AARs.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
The 193 direct XBD bumps and regenerated inventories are internally consistent, but two end-to-end publication blockers remain.
-
Complete the published reverse-dependency revision closure. Fourteen already-published packages keep immutable versions whose nuspecs still point to the pre-fix XBD revisions (
config.json:177,782,824,2123,2372,2624-2673,2718,3669,5248,5473-5523):Xamarin.AndroidX.Camera.MLKit.Vision,Core.GoogleShortcuts,Credentials.PlayServicesAuth,Wear.RemoteInteractions,Work.GCM,Xamarin.Google.AI.Edge.LiteRT,LiteRT.Support,LiteRT.Support.API,TransportBackendCct,AppActions.Suggestions,Xamarin.KotlinX.Coroutines.Play.Services, and the Audio/Text/Vision TensorFlow Lite Play Services task packages. NuGet selects the lowest applicable dependency, so consumers of these higher-level packages continue restoring the defective published XBD revisions even after the 193 direct packages are republished. Each current version is occupied and the next revision is free; bump all fourteen, then regeneratecgmanifest.jsonand the artifact-version table. -
Replace the historical dependency-only XBD packages. The exact mappings at
config.json:5605-5637still route the newly revised Gass, Ads Lite, and Firebase Analytics Impl packages toXamarin.GooglePlayServices.Ads.Base 120.0.0,Ads.Lite 120.0.0,Ads.Base 124.0.0.1, andMeasurement.Base 116.3.0. Those published nupkgs still contain duplicateXamarinBuildDownloadAndroidAarLibraryregistrations; Ads Base124.0.0.1and the already-published.2also embed the AAR, so.3is the first usable revision. Because dependency-only entries are skipped by normal binderator project generation, this PR cannot regenerate those packages as written. Publish fixed successors (120.0.0.1,120.0.0.1,124.0.0.3, and116.3.0.1respectively), update the four mappings, and regenerate their parent packages and inventories.
Release all published XBD AAR packages with the shared template fix that prevents embedding proprietary AARs alongside Xamarin.Build.Download references. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 017130ec-57f0-4759-86b2-e928fe0ba4a1
Regenerate artifact documentation and Component Governance metadata after revising the remaining published XBD package versions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e5da0c51-e7ab-4c79-a052-56ff6051ee10
7685acc to
9c550a6
Compare
Bump published reverse dependents and generate selected historical dependency-only XBD packages under unique project and external paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 017130ec-57f0-4759-86b2-e928fe0ba4a1
|
Addressed both review blockers in
Full binderation and metadata validation pass. The generated historical projects each have one downloaded AAR registration, no packed AAR, and no PublicAPI references. |
Keep the current reverse-dependency revision closure without adding binderator support for rebuilding historical dependency-only packages. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 017130ec-57f0-4759-86b2-e928fe0ba4a1
|
Scope update in |
|
@dalexsoto review |
Issue #1538 shows that already-published packages still use the old Xamarin.Build.Download templates, embedding proprietary AARs while also downloading them for consumers. The shared template fix from #1520 prevents this, but immutable current NuGet packages and their published reverse dependencies need new revisions to deliver it.
This change:
Historical dependency-only package versions remain unchanged. This PR intentionally limits the fix to the current package graph and contains no binderator code changes.
Fixes #1538